What do I have to change in this code for this to work?

<%
Dim varPassword, varCharacter ' Strings
Dim varContainsANumber ' Boolean
Dim i ' Integer
varPassword = Request.Form("password")
varContainsANumber = False
If varPassword <> "" And Not IsNull(varPassword) Then
' Password was entered - check length
If Len(varPassword) >= 6 Then
' Password is 6 characters or longer
' Check that at least one number is present
' Loop through string and test each character to see if it is numeric
i = 1
While i < Len(varPassword)
varCharacter = mid(varPassword, i, 1)
If IsNumeric(varCharacter) Then
' Number found, set flag to true
varContainsANumber = True
End If
i = i + 1
Wend
If varContainsANumber Then
' Password has passed criteria checks... do stuff...
Else
' Password failed criteria checks
' Return an appropriate error message to the user
End If
Else
' Password is shorter than 6 characters
' Return an appropriate error message to the user
End If
Else
' Password was not entered
' Slap user with a large fish
End If
%>


Any ideas appreciated

Thanks in advance

Karl.

what is it NOT doing ??

Originally Posted by chrishirst

what is it NOT doing ??

When the user enters there password and submits, the error in the title is displayed.

and the rest of the error message is ???
otherwise it would simply be a guess at which procedure caused the "invalid procedure error"

sorry.



Microsoft VBScript runtime error '800a0005'
Invalid procedure call or argument: 'Mid' /ChangePassword.asp, line 91

which is line "varCharacter = mid(varPassword, i, 1)"

in that case the usual cause would be a variable outside the allowed value

so either the loop value (i) is out of range or the password is empty.

have you debugged by printing the values to screen before the error occurs?

Why do you use a while/wend loop for something so basic BTW?

for i = 0 to len(varPassword)
' run check here
next

would accomplish what you want

or a simple regex would check the input at one call

<%
function CheckNumeric(strIn)
' function to validate numeric input
	dim objRE
	set objRE = New RegExp
	objRE.Pattern = "[0-9]"
	objRE.Global = True
	CheckNumeric = objRE.test(strIn)
	set regEx = nothing
end function
%>

Will return true if strIn contains a number false if not

Looks like you're missing an End If statement.

use of RegularExpression is optimized instead of loops