Tycoon Talk
Become a Big fish!
The number 1 forum for online business!
Post topics, ask questions, share your knowledge.
Tycoon Talk is part of Freelancer.com - find skilled workers online at a fraction of the cost.

CSS Forum


You are currently viewing our CSS Forum as a guest. Please register to participate.
Login



Reply
Old 12-19-2008, 11:12 AM a CSS code review
Andy Pugh's Avatar
Extreme Talker

Posts: 203
Name: Andy
Location: N.Ireland
Trades: 0
Hi guys,
Not sure if this is the right forum for this, however, I was hoping someone could perhaps give my CSS style technique a bit of a critique?

I use position:absolute; quite a bit and on reading a few threads within the forum, I'm led to believe that I should be using other options?

Hope you can help
Thanks,
Andy
the link : http://www.mediacubed.co.uk
__________________

Please login or register to view this content. Registration is FREE
Andy Pugh is offline
Reply With Quote
View Public Profile
 
 
Register now for full access!
Old 12-19-2008, 03:37 PM Re: a CSS code review
LadynRed's Avatar
Defies a Status

Posts: 10,016
Location: Tennessee
Trades: 0
Over use of positioning can lead to some big headaches, especially with IE. For the most part, you don't need a lot of position:absolute to achieve a layout, you're better off using the normal document flow and floats.

Looks like you also over-use <br>'s -- not a good practice. Spacing things out is what margins, padding and line heights are for

Your text should be inside proper <p></p> tags, you wouldn't write a document without paragraphs would you ?? No.. then you shouldn't do it with a web page either. In fact, you have ALL the text on your home page INSIDE an h6 tag -- definitely not the way it should be, your whole page is not a HEADING

Use of heading tags -- You've got <h6> tags for headings where you SHOULD be using H1, H2, or H3 level tags. In the hierarchy of an outline, an h6 is far less important than an H1 - and search engines pick up on PROPER heading tag usage .

I would also recommend stepping up to at least HTML 4.01 STRICT, that old 4.01 Transitional is just sloppy.

The way you've got your post-it notes positioned is acceptable though, that is a case where positioning make sense.
__________________
Web Goddess & Web Standards Evangelist :) - Tables Be Gone !!

Please login or register to view this content. Registration is FREE


Please login or register to view this content. Registration is FREE

LadynRed is offline
Reply With Quote
View Public Profile
 
Old 12-20-2008, 01:45 PM Re: a CSS code review
Andy Pugh's Avatar
Extreme Talker

Posts: 203
Name: Andy
Location: N.Ireland
Trades: 0
Hey, thanks for responding, I knew you'd be honest!
To be honest, I was always better with the design side of things as opposed to the coding, I always outsource a lot of that, I'm going to work on everything you recommended however and see if I can tidy it up a bit.....

thanks again,
Andy
__________________

Please login or register to view this content. Registration is FREE
Andy Pugh is offline
Reply With Quote
View Public Profile
 
Old 12-21-2008, 11:42 AM Re: a CSS code review
LadynRed's Avatar
Defies a Status

Posts: 10,016
Location: Tennessee
Trades: 0
I like your designs.. nice work Nothing wrong with sticking with your strengths and outsourcing to others for their strengths.

You might want to read thru this article on semantically correct coding:
http://brainstormsandraves.com/artic...ics/structure/

The use of proper headings is part of semantically correct code, and it does have advantages other than being nit-picky
__________________
Web Goddess & Web Standards Evangelist :) - Tables Be Gone !!

Please login or register to view this content. Registration is FREE


Please login or register to view this content. Registration is FREE

LadynRed is offline
Reply With Quote
View Public Profile
 
Old 12-21-2008, 12:41 PM Re: a CSS code review
Andy Pugh's Avatar
Extreme Talker

Posts: 203
Name: Andy
Location: N.Ireland
Trades: 0
Hey there,
thanks for sending that article, I have taken on board what you've said and cleaned up the code a little, I removed all references of the <br> tag. I moved it up to HTML 4.01 STRICT.

Could you have a look now and see what you think, I've only trawled through the home page so far so the others won't pass W3C yet.

Thanks,
Andy
__________________

Please login or register to view this content. Registration is FREE
Andy Pugh is offline
Reply With Quote
View Public Profile
 
Old 12-22-2008, 11:29 AM Re: a CSS code review
LadynRed's Avatar
Defies a Status

Posts: 10,016
Location: Tennessee
Trades: 0
Much better !!!
You might want to check your includes (if you're using them) because a validation error (Firefox plugin of HTML Tidy) says the opening <body> tag is missing.

I would make the "Welcome to MediaCubed" an H1 rather than a plain paragraph. I realize it's an image, but it's still a heading .
__________________
Web Goddess & Web Standards Evangelist :) - Tables Be Gone !!

Please login or register to view this content. Registration is FREE


Please login or register to view this content. Registration is FREE

LadynRed is offline
Reply With Quote
View Public Profile
 
Old 12-22-2008, 01:23 PM Re: a CSS code review
Andy Pugh's Avatar
Extreme Talker

Posts: 203
Name: Andy
Location: N.Ireland
Trades: 0
Hi there, OK I've tidied up those, I removed the javascript for the preloading images so that removed the body onload tag along with it which caused the missing body tag!

I think I'm getting there!? haha...
__________________

Please login or register to view this content. Registration is FREE
Andy Pugh is offline
Reply With Quote
View Public Profile
 
Reply     « Reply to a CSS code review
 

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off
Trackbacks are Off
Pingbacks are Off
Refbacks are Off





   
RSS Feed  Feeds: RSS   JS   XML
RSS Feed  Feeds for this forum: RSS   JS   XML



Page generated in 1.10213 seconds with 12 queries