HTML Forum

**webgrrl** · 09-21-2005, 07:41 PM

Hi, All -

I am using a Javascript function to swap photos onclick. Here is the img src:

<IMG id="PrimaryPhoto" name="PrimaryPhoto" onError="src='photos/viewhomenophoto.gif';" SRC="photos/<?=$photo1?>" WIDTH="330" ALIGN="middle" ALT="Click for Larger Photos" border="0" />

When I try to W3-validate the HTML, I get this error:

there is no attribute "ONERROR", there is no attribute "NAME"

Do I need a different DocType or something? My current DocType is:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">

I tried using an XHTML doctype but it broke all my css tags.

Any advice?

Thanks in advance,
WebGrrl

**chrishirst** · 09-22-2005, 02:12 AM

There is no onerror event. it doesn't exist in the DOM and because of that error, the name attribute also throws as an error.

The alt attribute should be used for text if the image is missing or fails to load, Other than that check for the image file existing server side and change the file name if it doesn't

**webgrrl** · 09-22-2005, 05:00 PM

Okay...I got rid of the onerror. (I checked for the image file existance with a php if statement instead.)

But I am still getting a there is no attribute "NAME" error when I try to validate the HTML.

What else can I try?

Thanks,
WebGrrl

**Minaki** · 09-23-2005, 04:35 AM

Try just taking the name attribute out? You've got the id attribute in there.

**webgrrl** · 09-23-2005, 02:54 PM

I tried taking the name attribute out but then my javascript didn't work...

function switchPhoto(oObj)
{

var cPath = '';
cPath = oObj.src;

if (cPath == 'images/placeholder.gif') {
//do nothing
}
else {
//swap photo
document.PrimaryPhoto.src = oObj.src;
}

}

WebGrrl

**ElectricSheep** · 09-25-2005, 05:31 AM

You could reference the image by position in the images array so instead of

document.PrimaryPhoto.src = oObj.src;

try

document.images[index].src = oObj.src;

index would indicate the position of the image in the document. The first image would be referenced as 0, the third 2 and so on.

**Minaki** · 09-25-2005, 08:57 AM

There has to be another way of doing it than that. I don't know a lot of JavaScript myself...
It just seems a very bad idea to reference images by their position in the document, cos this could easily change - and then you'd have to work out the new position and changethe code.

**chrishirst** · 09-25-2005, 10:37 AM

Code:

document.getElementById("PrimaryPhoto").src =

**ElectricSheep** · 09-25-2005, 12:10 PM

This is the W3C way to do it but won't work in older / non-standard following browsers.

Referencing elements through number rather than name actually makes it very easy to loop through all images, forms, form elements, applets, scripts, stylesheets etc applying something to each as you do. This approach pre-dates W3C DOM so is ideal for wide audiences - even Netscape 4 will understand!

Anyway, you could use the name attribute validly with the following <!DOCTYPE> :

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/REC-html401/loose.dtd">

HTML Forum

Find a Professional HTML Freelancer!

FREE Outsourcing eBook!