hiya

i have a bit of code that works well, goes though 8 images fine.. named 1.jpg through to 8.jpg

.................................................. .......
<script type="text/javascript">
<!--
function move(depth) {
if (depth < 8) {
depth++;
document.getElementById("move").src = depth + ".jpg";
}
setTimeout("move("+depth+");",30);
}
//-->
</script>
.................................................. ......
<a href="#" onclick="move(0)">SPIN</a>
.................................................. ......

however

if i change it to this
.................................................. .....
<script type="text/javascript">
<!--
function move(depth,stop) {
if (depth < stop) {
depth++;
document.getElementById("move").src = depth + ".jpg";
}
setTimeout("move("+depth+");",30);
}
//-->
</script>
.................................................. .......
<a href="#" onclick="move(0,6)">SPIN</a>
.................................................. .......
by adding a second variable in "stop" it stops the script completely.

normall as the first example it would show images from 1 to 8

but with the stop in it should show from 1 to 6,, but its not working.

i am new to javascript btw

can you see whats wrong?

thanks

shaz x

I can't tell from looking at the code. Is this on a page somewhere, reachable by the outside world? I could take the code, and then copy and rename a bunch of images ... but I'm lazy.

If you're using Firefox, try using Firebug, and setting a breakpoint in your move function. This will let you run the script line by line and see what's going on ... you can also hover the mouse over your variables and see what's inside them.

The reason your second code is not working is because you're not passing it two parameters when you call the function with the setTimeout.

So if you change the setTimeout part to: setTimeout("move("+depth+","+stop+");",30); it will work. Also if you have the id the same name as the name of the function it wont work in Firefox for some reason, so you'll have to make sure the id value of the img tag is different from the name of the function you're calling.

You're doing very well for being new to javascript; you'll be a pro in no time.
I'm still new myself, but I'm learning it pretty fast.

Oh btw, about firebug, it causes insane memory leaks. My ram usage went up 300mb in like 15 clicks, PF usage went up 1gb. After hours of trying to figure out why my javascript code was causing memory leaks in FireFox I finally decided to see if it was any of the firefox addons causing the problem, and sure enough after I uninstalled Firebug I had no more memory leaks.

Hopefully FireBugs memory leak problems are fixed soon because it's a great tool.

Thanks SillyWilly that solved it and it now works good!
Shaz x

You bet!

If you ever have any trouble again, or questions then don't spend all day trying to figure them out, just ask in here. Although it is good to spend some time trying to figure them out on your own so that you'll get better at trouble shooting and finding problems in code.

I've become pretty good at finding errors in code since I was coding in a blurry monitor up until a few days ago, which caused me to not see typos very well.