Hello,

I have a form. Three numbers will be entered into it. I don't want this form to be valid if any two or three of the three numbers are the same as each other (i.e. they all need to be different).

Any ideas? Hopefully this is an easy one for anyone who knows their JavaScript stuff. I'm running jQuery on this page as well so if that makes it easier, go for it.

HTML code as it stands:

<label for="firstchoice">1st Choice</label>
<input type="text" id="firstchoice" />
<label for="secondchoice">2nd Choice</label>
<input type="text" id="secondchoice" />
<label for="thirdchoice">3rd Choice</label>
<input type="text" id="thirdchoice" />

Thanks in advance

Scott.

<script type="text/javascript">
var submitForm = true;
var firstChoice = document.getElementById("firstchoice");
var secondChoice = document.getElementById("secondchoice");
var thirdChoice = document.getElementById("thirdchoice");

if (firstChoice == secondChoice || secondChoice == thirdChoice) {
     submitForm = false;
} else if (firstChoice == thirdChoice) {
     submitForm = false;
}
</script>

I'm still learning JS, so this form is not perfect. Also your form needs the <form action="" method=""> ... </form> tags.

this;

var firstChoice = document.getElementById("firstchoice")

will return the object NOT it's value.

So if they are all input elements, they will all match regardless of what the user has entered

Originally Posted by chrishirst

this;

var firstChoice = document.getElementById("firstchoice")

will return the object NOT it's value.

So if they are all input elements, they will all match regardless of what the user has entered

Then would this work?

<script type="text/javascript">
var name = name.value;
var email = email.value;

if (name == email) {
     alert("Error, your name can not match your email.");
}
</script>

not quite;

you have to qualify each object with it's parentage.
so this;

var name = name.value;
var email = email.value;

would be

var name = document.formname.name.value;
var email = document.formname.email.value;

Unlike many OOP languages, javascript has no with object qualifier, but you can assign the parent(s) to a variable and use that. So it can be shortened to

var parent = document.form;
var name = parent.name.value;
var email = parent.email.value;

And there are of course several other ways to reference an element.

Sorted, thanks for your help guys. This is what I ended up with

<form id="theform" action="choicesub.asp" name="theform" method="post" onsubmit="return validate();">
      <fieldset>
          <h3>Choices</h3>
            <label for="firstchoice">1st Choice</label>
            <input type="text" id="firstchoice" value="" />
            <label for="secondchoice">2nd Choice</label>
            <input type="text" id="secondchoice" value="" />
            <label for="thirdchoice">3rd Choice</label>
            <input type="text" id="thirdchoice" value="" />
      </fieldset>
    </form>

function validate() {
  
  var choiceone = document.theform.firstchoice.value;
  var choicetwo = document.theform.secondchoice.value;
  var choicethree = document.theform.thirdchoice.value;

  if (choiceone == choicetwo) {
    alert("Error - Two or more of your choices are the same. Please reset your choices and try again.");
    return false;
  }

  else if (choiceone == choicethree) {
    alert("Error - Two or more of your choices are the same. Please reset your choices and try again.");
    return false;
  }

  else if (choicetwo == choicethree) {
    alert("Error - Two or more of your choices are the same. Please reset your choices and try again.");
    return false;
  }
  
  return true;

}

What's better than it working is that I nearly understand it!

Scott.