I have my navigation coded like so

<ul id="nav">
        <li><a href="../contact.htm">contact us</a></li>
        <li><a href="../about.htm">about us</a></li>
        <li><a href="../myAccount/">my account</a></li>
        <li><a href="../register.htm">sign up</a></li>
        <li><a href="../search.htm">search</a></li>
        <li></li>
      </ul>

and Im using the following code to make jQuery change the class of the currently viewed page to my 'active' class that has been specified in the CSS

// make the current page show as active on the nav
$(document).ready (function () {
  var path = location.pathname.substring(1);
  $('#nav a[@href$="' + path + '"]').addClass('active');
});

But nothing happens! I check the Firefox error console (which doesn't even issue an alert for some reason) and I get a message similar to the following

Error: [Exception... "'Syntax error, unrecognized expression: [@href$="C:/Users/Pealo/Documents/homework/levelH/researchDevelopment/penguinpages.co.uk/register.htm"]' when calling method: [nsIDOMEventListener::handleEvent]" nsresult: "0x8057001e (NS_ERROR_XPC_JS_THREW_STRING)" location: "<unknown>" data: no]

I'm clueless on how to fix it though! Any help would be great.

$("#nav a").each(function() {
     if(this.href == window.location) $(this).addClass("active");
});

thanks that works! Im guessing the 'each' method is used to cycle through each item in the list?

I was going by this tutorial:
http://jeroencoumans.nl/journal/simp...le-jquery-menu

But it didn't work in my case! No too sure why though

Hmmm I've just thought, I don't know if this method would work in cases such as where the location is something like

"search.php?companyId=23"

Do you know of a way around this by any chance?

$("#nav a").each(function() {
if(this.href == window.location || this.href == document.location.protocol + "//" + window.location.hostname + window.location.pathname)
     $(this).addClass("active");
});

or, you could use CSS attribute selectors. I think this will work:

var path = document.location.protocol + "//" + window.location.hostname + window.location.pathname;
$("#nav a[href=" +  window.location + "], #nav a[href=" + path + "]").addClass("active");

It is important to note that paths contained inside of any href property always manifest as absolute paths in JavaScript, no matter how they are expressed in the HTML.

Thanks!