JavaScript Forum

**Weedave** · 05-23-2009, 01:28 PM

hey yesterday i decided to learn jaascript and at the moment i have a button tat when u press it it will tel u iff you are lucky or not, it also asks for your name...well thats what its ment to do atm nothing hapens when u press the button here is the coding i have atm.

Code:

<html>
<head>
<script type ="text/javascript">
function luck();
{
//asks to enter name,
var name=prompt("Please enter your name","Harry Potter");
if (name!=null && name!="")
{
/*works out random number if more than 0.5 then
*/the person is lucky then displays results
var r=Math.random();
if(r>0.5)
 {
 document.write("lucky");
 }
else 
 {
 document.write("unlucky")
 }
}
}
</script>
</head>
<body>
<form>
//button that redirects to the top function
<input type="button" value="Click here to see how lucky you are =D" onclick="luck()" />
</form>
</body>
</html>

im sure its simple im just not seeing it

**willcode4beer** · 05-26-2009, 05:58 AM

Ok, there are a few problems;
first:

Code:

function luck();

the semi-colon means the function is over, change it

Code:

function luck()

Next, your comments are broken:

Code:

/*works out random number if more than 0.5 then
*/the person is lucky then displays results

Change it so, all of the comment is commented:

Code:

/*works out random number if more than 0.5 then
  the person is lucky then displays results
*/