Hey,

Recently I found out that my website seems to show a javascript warning in Internet Explorer - http://www.lilwaynehq.com - You can see the message in the screenshot below:



I know that it has something to do with my logo code (which I use to swap images every few seconds):

script language="JavaScript">
  var ImageArr1 = new Array("http://www.lilwaynehq.com/images/lilwaynehqlogo-800-big.jpg","http://www.lilwaynehq.com/images/lilwaynehqlogo2-800-big.jpg");
  var ImageHolder1 = document.getElementById('Rotating1');
  
  function RotateImages(whichHolder,Start)
  {
      var a = eval("ImageArr"+whichHolder);
      var b = eval("ImageHolder"+whichHolder);
      if(Start>=a.length)
          Start=0;
      b.src = a[Start];
      window.setTimeout("RotateImages("+whichHolder+","+(Start+1)+")",6500);
  }
  
  RotateImages(1,0);
  RotateImages(2,0);
  
</script>

Does anyone know how I can fix this?

Thanks, apperciate it

When I see this:

RotateImages(2,0);

and I look into the RotateImages function, I see that
the array it uses is based on the first parameter:

  function RotateImages(whichHolder,Start)
  {
      var a = eval("ImageArr"+whichHolder);
      var b = eval("ImageHolder"+whichHolder);
      if(Start>=a.length)
          Start=0;
      b.src = a[Start];
      window.setTimeout("RotateImages("+whichHolder+","+(Start+1)+")",6500);
  }

So, by calling "RotateImages(2,0)", you must have an ImageArr2 array and an ImageHolder2 element already defined with the images you want.

Otherwise, if you want 2 times the same image rotation, but in different placeholders, you will need to do something like

var ImageArr1 = ImageArr2
 = new Array("http://www.lilwaynehq.com/images/lilwaynehqlogo-800-big.jpg","http://www.lilwaynehq.com/images/lilwaynehqlogo2-800-big.jpg");
var ImageHolder1 = document.getElementById('Rotating1');
var ImageHolder2 = document.getElementById('Rotating2');

This will make the images arrays ImageArr1 and ImageArr2 identical, but give a specific placeholder for both.

Originally Posted by tripy

When I see this:

RotateImages(2,0);

and I look into the RotateImages function, I see that
the array it uses is based on the first parameter:

  function RotateImages(whichHolder,Start)
  {
      var a = eval("ImageArr"+whichHolder);
      var b = eval("ImageHolder"+whichHolder);
      if(Start>=a.length)
          Start=0;
      b.src = a[Start];
      window.setTimeout("RotateImages("+whichHolder+","+(Start+1)+")",6500);
  }

So, by calling "RotateImages(2,0)", you must have an ImageArr2 array and an ImageHolder2 element already defined with the images you want.

Otherwise, if you want 2 times the same image rotation, but in different placeholders, you will need to do something like

var ImageArr1 = ImageArr2
 = new Array("http://www.lilwaynehq.com/images/lilwaynehqlogo-800-big.jpg","http://www.lilwaynehq.com/images/lilwaynehqlogo2-800-big.jpg");
var ImageHolder1 = document.getElementById('Rotating1');
var ImageHolder2 = document.getElementById('Rotating2');

This will make the images arrays ImageArr1 and ImageArr2 identical, but give a specific placeholder for both.

Sorry, I didn't quite understand you there.

Should I basically do:

RotateImages(1,0);

Or what you said about the 2 ImageHolders?

Thanks

What I say is that "RotateImages(1,0);" uses the images defined in
ImageArr1 to place them in the placeholder ImageHolder1.

If you use "RotateImages(2,0);", then you must have ImageArr2 and ImageHolder2 defined.
If you call "RotateImages(3,0);", then you will need ImageArr3 and ImageHolder3.

And so on.
If you want 2 rotators with the same images, you must define 2 arrays of images with the same content, and give different placeholders.

Thanks very much, that seemed to work.

But the bad news is that there is now another error:

<script language="JavaScript">
var ImageArr1 = ImageArr2
 = new Array("http://www.lilwaynehq.com/images/lilwaynehqlogo-800-big.jpg","http://www.lilwaynehq.com/images/lilwaynehqlogo2-800-big.jpg");
var ImageHolder1 = document.getElementById('Rotating1');
var ImageHolder2 = document.getElementById('Rotating2');
  
  function RotateImages(whichHolder,Start)
  {
  	var a = eval("ImageArr"+whichHolder);
  	var b = eval("ImageHolder"+whichHolder);
  	if(Start>=a.length)
  		Start=0;
  	b.src = a[Start];
  	window.setTimeout("RotateImages("+whichHolder+","+(Start+1)+")",6500);
  }
  
  RotateImages(1,0);
  RotateImages(2,0);
  
</script>

Do you know what this could be?

Thanks

Nope, don't know, and running no windows boxes, I don't have a IE to test.
Sorry.

Oh okay then.

Does anyone else have any ideas how to fix this?

Thanks

Originally Posted by Danaldinho

Thanks very much, that seemed to work.

But the bad news is that there is now another error:

<script language="JavaScript">
var ImageArr1 = ImageArr2
 = new Array("http://www.lilwaynehq.com/images/lilwaynehqlogo-800-big.jpg","http://www.lilwaynehq.com/images/lilwaynehqlogo2-800-big.jpg");
var ImageHolder1 = document.getElementById('Rotating1');
var ImageHolder2 = document.getElementById('Rotating2');
  
  function RotateImages(whichHolder,Start)
  {
      var a = eval("ImageArr"+whichHolder);
      var b = eval("ImageHolder"+whichHolder);
      if(Start>=a.length)
          Start=0;
      b.src = a[Start];
      window.setTimeout("RotateImages("+whichHolder+","+(Start+1)+")",6500);
  }
  
  RotateImages(1,0);
  RotateImages(2,0);
  
</script>

Do you know what this could be?

Thanks

Anyone got any ideas?

Thanks