Hello, and again, I have a simple code that for a reason of it's own, it doesn't decide to work...

<script type="text/javascript">
function ChangeView(a,b) {
document.b.style.color=a;
}
</script>
<a class="viewbutton" onclick="ChangeView('white,historydiv');">History</a>
<div id="historydiv">
History Div
</div>

All that should do (but it doesn't) is first have a script that contains a function called ChangeView, that uses values 'a' and 'b'. Then there's a simple link that onclick, passes the values 'white' and 'historydiv' to the script, which should turn 'historydiv''s text white.


But it doesn't.


I've been at this for a long time now, all over the place, and I've gotten it to change historydiv if I specify it in the script, like this:

function ChangeView(a) {
document.historydiv.style.color=a;
}

But I want it to be able to do it from script, so I don't have to make millions of these to accommodate my million (much less) divs.

I have no idea what the problem of the code it (the first one). Am I missing some single quotes or something stupid like that? No error messages, just not working...

And BTW, there is no CSS for my historydiv. No fixed styles.

Let's switch to DOM based coding and correct your single quote error on the function call (and return false on the anchor tag):

<script type="text/javascript">
function ChangeView(a,b) {
  document.getElementById(b).style.color = a;
}
</script>
<a class="viewbutton" onClick="ChangeView('white','historydiv');return false;">History</a>
<div id="historydiv">
History Div
</div>

Thanks, JeremyMiller! Works great! Just one (hopefully simple) question.

That wasn't my actual code. Why would I want to turn text white? My actual code is a whow/hide toggle switch. It toggles the display on a DIV.

<script type="text/javascript">
function ChangeView(a,b) {
  if (b.style.display = none) {
   document.getElementById(b).style.display = block;
  }
  else if (b.style.display = block) {
   document.getElementById(b).style.display = none;
  }
}
</script>
<a class="viewbutton" onClick="ChangeView('block','historydiv');return false;">History</a>
<div id="historydiv" style="display: none;">
Contents Of HistoryDiv
</div>

What that should do is the same thing as before, but change it to toggle display from none to block, and check whether to turn it to none or block.

In 'Programmer's English';
"If historydiv is block, turn it to none, else if it's none, turn it to block."

But it just doesn't work, another stupid quote mistake? Before, I had what you have now (I didn't post it, it didn't work anyway), but without the 'return false'. With 'return false' it works. Hmm...

Using a switch statement is a more efficient method than a bunch of "if" statements

http://www.modtalk.co.uk/_site/code/.../text-element/

<span id="t0" onclick="toggle('h0',this.id);" style="cursor:pointer;">Show</span><span> 0</span>
<span id="t1" onclick="toggle('h1',this.id);" style="cursor:pointer;">Show</span><span> 1</span>

<div id="h0" style="visibility:hidden;display:none"> This is normally hidden</div>
<div id="h1" style="visibility:hidden;display:none"> This is normally hidden as well</div>

function toggle(id,sender){
	var e = document.getElementById(id).style;
	var t = document.getElementById(sender);
	var disp = e.display;
	var vis = e.visibility;
    var txt = t.innerHTML;
	switch(disp) 
		{
		case 'none':
			disp = 'block';
			vis =  'visible';
            txt = 'Hide';
            
			break;
		case 'block':
			disp = 'none';
			vis =  'hidden';
            txt = 'Show';
			break;
		default:
			disp = 'none';
			vis =  'hidden';
            txt = 'Show';
		}			
	e.display = disp;
	e.visibility = vis;
    t.innerHTML = txt;

	}
	
</script>

OMG thanks!!!!!!

All this script does is toggle the visibility of a div when you click on a button.

Currently yep, but you can add what ever else you need it to do to the script.