Hi forum,

I am running a function for change password.........this function isn't checking any of the condition given below..........please let me know where I mistook.

function valid_password(frm)
{
    var err;
    if(frm.old.value=="")
    {
        err = "Please enter old password.";
        alert(err);
        frm.old.focus();
        return false;
    }
    else if(checkforpassword(frm.old.value))
    {
        err = "Invalid characters in old password.";
        alert(err);
        frm.old.focus();
        return false;
    }
    if(frm.newpass.value=="")
    {
        err = "Please enter new password.";
        alert(err);
        frm.newpass.focus();
        return false;
    }
    else if(checkforpassword(frm.newpass.value))
    {
        err = "Invalid characters in new password.";
        alert(err);
        frm.newpass.focus();
        return false;
    }
    else
    {
        if(frm.confirmpass.value=="")
        {
            err = "Please confirm password.";
            alert(err);
            frm.confirmpass.focus();
            return false;
        }
        else if(frm.confirmpass.value!=frm.newpass.value)
        {
            err = "Confirm password mismatch.";
            alert(err);
            frm.confirmpass.focus();
            return false;
        }
    }
    return true;
}

Elaborating my query............I am calling this to my other page like this.

<form id="frm" name="frm" method="post" action="controller/changepass_controller.php" onSubmit="javascript: return valid_password(this);">
<table width="530" border="0" cellspacing="0" cellpadding="0">
<tr>
<td align="left" valign="top">
<div align="center" class="style1">
<?php
if($_SESSION["msg"]!="")
{
echo $_SESSION["msg"];
$_SESSION["msg"]="";
}
?>
</div><br>
<table width="500" border="0" cellspacing="5" cellpadding="2">
<tr>
<td align="left" valign="middle" class="normltext">Old Password:<span class="style1">*</span> </td>
<td align="center" valign="middle" class="normltext">&nbsp;</td>
<td width="288" class="textblackblod"><label>
<input name="old" type="password" class="manditoryfield" id="old" style=" width:170px; height:22px;">
</label></td>
</tr>
<tr>
<td align="left" valign="middle" class="normltext">New Password:<span class="style1">*</span> </td>
<td align="center" valign="middle" class="normltext">&nbsp;</td>
<td class="textblackblod"><input name="newpass" type="password" class="manditoryfield" id="newpass" style=" width:170px; height:22px;"></td>
</tr>
<tr>
<td align="left" valign="top" class="normltext">Confirm Password:<span class="style1">*</span> </td>
<td align="center" valign="top" class="normltext">&nbsp;</td>
<td class="textblackblod"><input name="confirmpass" type="password" class="manditoryfield" id="confirmpass" style=" width:170px; height:22px;"></td>
</tr>

<tr>
<td align="right" valign="middle" class="normltext">&nbsp;</td>
<td align="left" valign="middle" class="normltext">&nbsp;</td>
<td align="left" valign="top" class="textblackblod"><table width="185" border="0" cellspacing="0" cellpadding="0">
<tr>
<td width="92" align="left" valign="top"><table width="64" border="0" align="left" cellpadding="0" cellspacing="0">
<tr>
<td width="6"><img src="img/btm-lt.jpg" width="7" height="28" alt="" /></td>
<td width="52" align="center" valign="middle"><input name="Submit" type="submit" class="btm" value="Submit" /></td>
<td width="6" align="left"><img src="img/btm-rt.jpg" width="7" height="28" alt="" /></td>
</tr>
</table></td>
<td width="93"><table width="64" border="0" align="left" cellpadding="0" cellspacing="0">
<tr>
<td width="6"><img src="img/btm-lt.jpg" width="7" height="28" alt="" /></td>
<td width="52" align="center" valign="middle"><input name="Submit2" type="reset" class="btm" value="Reset" /></td>
<td width="6" align="left"><img src="img/btm-rt.jpg" width="7" height="28" alt="" /></td>
</tr>
</table></td>
</tr>
</table></td>
</tr>
</table></td>
</tr>
</table>
<input type="hidden" name="work" value="changepassword"/>
</form>

I've checked it trice but unable to find the problem............its not checking any field from java script.

But its working when I paste it within the page......ur help would be appreciated.

Originally Posted by Isabella_Smith

But its working when I paste it within the page......ur help would be appreciated.

Then there must be something wrong with the way you're including the .js file, but you haven't shown that.