Hi

Ive got a piece of js code which currently i am repeating as i dont know javascript and cant make a loop. Please help me arrange this code so it loops. This is the code as is:

<script>
if(document.images) 
{ col = new Array() 
for(i=0;i<10;i++) 
{ col[i] = new Image() 
col[i].src = "http://www.webmaster-talk.com/images/col" + i + ".gif" } } 

function glassauto1() 
{if(document.images){document.colswitch1.src="http://www.webmaster-talk.com/images/col"+document.doorglass.door1glass.selectedIndex+".gif"}}
window.onerror=null; 

function glassauto2() 
{if(document.images){document.colswitch2.src="http://www.webmaster-talk.com/images/col"+document.doorglass.door2glass.selectedIndex+".gif"}}
window.onerror=null; 
</script>

and this is along the lines of what i want

<script>
if(document.images) 
{ col = new Array() 
for(i=0;i<10;i++) 
{ col[i] = new Image() 
col[i].src = "http://www.webmaster-talk.com/images/col" + i + ".gif" } } 

var numdoor = doorform.numdoor.value; // for example 2
for(b=1; b< numdoor ;b++)
{
function glassauto[b]() 
{if(document.images){document.colswitch[b].src="http://www.webmaster-talk.com/images/col"+document.doorglass.door[b]glass.selectedIndex+".gif"}}
window.onerror=null; 
}

</script>

Id be most greatly if you can help me sort this simple script.

if (document.images)
{
    var col = new Array();
    for (var i = 0; i < 10; i ++)
    {
         col[i] = new Image();
         col[i].src = "http://www.webmaster-talk.com/images/col" + i + ".gif"
    }
}

var numDoor = doorform.numdoor.value;
for (var i = 0; i < numDoor; i++)
{
    if (document.images)
    {
        document.colswitch[b].src="http://www.webmaster-talk.com/images/col"+document.doorglass.door[i]glass.selectedIndex+".gif"
        window.onerror = null;
    }
}

Only problem is where you have a [i] inside the url. I wasn't sure how it was supposed to go, but that is most certainly invalid syntax.

Yeah thanks for looking. I have tried various ".i." and [i] but nothing seems to work. il just stick with 5 repetitions of the same code i think.

if you can post the full HTML, or working HTML, I could help... I just need a better idea of what you are trying to do... Looks like you want to change an image when a drop down is selected. Why not just do:

function swap(dropdownValue, imgTarget) {
     iTarget = document.getElementById(imgTarget);
     imgTarget.src = "http://www.webmaster-talk.com/images/col" + dropdownValue + ".gif";
}

and call it with

onchange="swap(this.selectedIndex,'theImage');"

in the select box?

Hi funkdaddu

thanks for looking at this thread, ive given up on this particular problem now and just used 5 repeated sections of code.

I do have a very similar problem will il post up shortly

i believe you were looking for something along the lines of:

document.images["imageName"+ x].src = my_img.src;