i am having problems with a simple imageswapping function - it works right in ie but not in firefox. here is part of my code and the firefox error which is displayed. i figure that i should be checking for firefox browser as well, but i have other stuff that does work and didn't have to do a browser check. thanks in advance



browserName = navigator.appName;
browserVer = parseInt(navigator.appVersion);
if (browserName == "Netscape" && browserVer >= 3) browserVer = "1";
else if (browserName == "Microsoft Internet Explorer" && browserVer == 4) browserVer = "1";
else browserVer = "2";


//image loading function used on photo pages
function load_pics(num_pics, fold_name){
for (i=1; i <=num_pics; i++)
{
photo[i] = new Image(); LINE 50
photo[i].src = fold_name + "pic" + i + ".jpg";
}
}
//image swapping function:
function image_swap(image_id, image_name) {
if (browserVer == 1) {
document.images[image_id].src = eval(image_name + ".src"); LINE 57
return true;

}}


Error: photo is not defined
Source File: XXXX(i changed this)
Line: 50

Error: photo is not defined
Source File: XXXXLine: 57

Put this line at the very beginning of your Javascript:

var photo = new Array();

This will declare the variable "photo" as an array regardless of browser.

thanks. i tried that before though, and nothing will work though. i get an "Object Expected" error. any idea? i am pretty sure that it is the array causing problems, because i have other images being swapped, but i preloaded them with the actual paths.

What's the page itself look like?

the part the code is for i just a table (2 col & 1 row) on the left side is a large picture, on the right side is number of thumbnails. whenever you mouseover one of the smaller ones it shows a large version of it on the picture on the right.

It would help more if you could give us the rest of the code, but I think the bug (or at least, one of them) is that you're using document.images[..], which is not allowed in firefox (pretty sure, but not 100%) [edit:I was wrong. document.images is allowed in firefox too]. Use document.getElementById(..) instead.

Don't forget to add

photo[i].id = groupname + "_" + i;

or something similar.

Btw. are you sure that it's executed? Like, if (browserVer == 1) {. I wouldn't be too sure browserVer == 1 in firefox..?

Also, have you written this code yourself?

the browser stuff i got from a turorial, the rest i was able to come up with. at the bottom(in blue) are the lines of code where i actually call the functions in. well, here is all of the code in my javascript file:

//var photo = new Array();

//detect browser:
browserName = navigator.appName;
browserVer = parseInt(navigator.appVersion);
if (browserName == "Netscape" && browserVer >= 3) browserVer = "1";
else if (browserName == "Microsoft Internet Explorer" && browserVer == 4) browserVer = "1";
else browserVer = "2";
//preload all the images :
if (browserVer == 1) {
default_image = new Image()
default_image.src = "main_menu/select_home.jpg"
select_home = new Image();
select_home.src = "main_menu/select_home.jpg";

i got the pages to work right, but it is not really a "good" fix. IE is having problrms with the photo = new Array(num_pics); , but netscape and firefox(whose browsername is "netscape" for some reason) need it in order to work. does anyone know why IE would be having a problem with it? here is the function that is working. thanks in advance...


function load_pics(num_pics, fold_name){

if (browserName == "Netscape") photo = new Array(num_pics);

for (i=1; i <=num_pics; i++)
{
photo[i] = new Image();
photo[i].src = fold_name + "pic" + i + ".jpg";
}
}

Instead of:
if (browserName == "Netscape")

You might wanne use:
if(!document.all)