Hi. I have created a javascript testimonial rotator in the style of http://en.helldesign.pl/ at http://www.ourprojects.biz/borderline/site/ and it works fine in Firefox but for some reason in Internet Explorer the error "'nodeList[...]' is null or not an object" appears when the script is run.

My page contains eight testimonials in an unordered list. Every 10 seconds the script is called. My CSS sets them all to display none, except for the one with class="conspic".

        <script type="text/javascript">
            setInterval("timing()",10000);
        </script>

The script then goes through the list, fades out the current testimonial, makes the next one down active by changing the class, and then fades it in using a script.aculo.us effect. There are also seven other list items on the page before my testimonials so when it gets to the last testimonial I start again from the eighth list item.

// JavaScript Document
var flag = 0;
var cnt = -1;
var nodeList = document.getElementsByTagName("li");

function timing()  {
    flag = 0;
    cnt = -1;
    while (flag==0){
        cnt++;
        rotation(cnt);
    }
}
    
function rotation(i) {
    if (nodeList[i].getAttribute('class')=="conspic"){
        new Effect.Fade('testimonials',{ 
            afterFinish : function(effect){
                nodeList[i].setAttribute('class','');
                if (i>13)
                nodeList[7].setAttribute('class','conspic');
                else
                nodeList[i+1].setAttribute('class','conspic');
                new Effect.Appear('testimonials');
            }                         
        });
        flag = 1;
    }
}

Anyone got any ideas why it don't work in IE or maybe even a more efficient way to do this?

Elements in the DOM are UPPERCASE. When you use this, it should be this:

var nodeList = document.getElementsByTagName('LI');

Also because class is a reserved keyword in javascript, you can't get the attribute like that, you must do:

if(nodeList[i].className == 'conspic') { ...

As well as using className in all the cases that use 'class'.

Cheers,

MC

Thanks so much for your quick response, it works absolutely fine now!