I've got image links on my site, and Internet Explorer won't open them. If I try to right-click open in new window, IE says it can't open the page. My pages are W3C valid, and all other browsers have no problem with the following coding. Help with a workaround?

This is what's in my head section:
<script language="JavaScript" type="text/javascript">
<!-- Hide script from old browsers

function newWindow(imgjpg) {
imgName = "../images/cabinets/" + imgjpg
winName = imgjpg + "Win"
imgWindow = window.open(imgName,winName)
imgWindow.focus()
}

// End hiding script from old browsers -->
</script>

Each of my image links has a variation of this (and they're each enclosed in a td tag if that makes a difference)

<a href="javascript:newWindow('concept1.jpg')">

Thanks to anyone who can help.

I think in IE you need to use the var keyword when declaring any new variable. Try:

function newWindow(imgjpg) {
var imgName = "../images/cabinets/" + imgjpg
var winName = imgjpg + "Win"
var imgWindow = window.open(imgName,winName)
imgWindow.focus()
}

I think that will fix the IE issue.

Tried doing that, didn't work. Wouldn't even open anything, much less put out a page not found window.

Thanks just the same, though.

Why not link directly to the jpeg for non-JS browsers, and then do:

function newWindow(imgjpg) {
winName = imgjpg + "Win"
imgWindow = window.open(imgjpg,winName)
imgWindow.focus()
}

then do onclick="newWindow(this.href); return false;"

That way your images are still accessible to non-js enable browsers and the regular link will work as well.

Avoid using a dot in the window target name.
In your code, "winName" will contain a dot and fail - "concept1.jpgWin".
Omit the dot and your code will not throw an error.

funkdaddu, that worked beautifully. Thanks!

Originally Posted by ElectricSheep

Avoid using a dot in the window target name.
In your code, "winName" will contain a dot and fail - "concept1.jpgWin".
Omit the dot and your code will not throw an error.

Yup, I missed that... if you don't need to access the windows after they've been opened, you can just leave the name out. It should make a new one for each window:

function newWindow(imgjpg) {
imgWindow = window.open(imgjpg)
}

A related question is this:

Is it now just completely inadvisable to use the javascript: attribute within a XHTML tag?