JavaScript Forum

**Padawan Geek** · 09:25 PM

I have two scripts running on the same page, but when I load the page, the one that has the alert in it wont work. When I take the other one out, the alert works fine. Why is this?

Here is the code.

alert:

Code:

window.onload = construction;

function construction() {
    alert("This site is still under construction. Some of the links and effects may not work. Still, you can look around.")
}

other one:

Code:

window.onload = timegreeting;

function timegreeting() {
    var now = new Date();
    var greet;

    if (now.getHours() < 11) {
        greet = "<p>Good morning!</p>";
    }
    
    else if (now.getHours() < 17) {
        greet = "<p>Yo!</p>";
    }

    else {
        greet = "<p>Good evening!</p>";
    }
    
    document.getElementById("greeting").innerHTML = greet;
}

Thanks!

**JeremyMiller** · 04-13-2007, 12:39 AM

You're writing over the window.onload event twice:

Code:

window.onload = construction;

and

Code:

window.onload = timegreeting;

Instead, use the DOM methods (can't remember the ones to add events to the window object) or use a control function. For example,

Code:

window.onload = pageLoader;
function pageLoader() {
  construction();
  timegreeting();
}

The advantage of using DOM (not shown above) is that your code will work with other code that does (but break if it doesn't).

**jito** · 04-13-2007, 02:34 AM

Or attach the second function with body onload inside the page.

**willcode4beer** · 04-13-2007, 10:54 AM

an alternative (but, in the same spirit) to Jeremy's suggestion:

Code:

window.onload = function () {
  construction();
  timegreeting();
}

**Padawan Geek** · 04-13-2007, 09:01 PM

Thanks guys, but is there a way to make it get the functions from seperate files, like have it go

Code:

window.onload = function () {
bla bla bla
}

and have it call out to other files that have the scripts in them, so that I can have each thing in it's own file.

**JeremyMiller** · 04-13-2007, 10:48 PM

Well, you don't call other files, you can include them, but that'd be best done using PHP to minimize the overhead of loading the javascript. You could then call all appropriate functions. For example, in a PHP file you may have the following

PHP Code:


			
 <?php
   if (whatever you want) {
    echo "<script src=\"my_file.js\" type=\"text/javascript\" ></script>\n";
   }
 ?>
window.onload = pageLoader;
function pageLoader() {
  construction();
  timegreeting();
<?php
  if (whatever you want) {
    echo "my_function();\n";
  }
?>
}

Where my_function() is defined in my_file.js

**ADAM Web Design** · 04-13-2007, 11:36 PM

You can call both of your functions in a body tag as well using onload.

<body onload="construction();timegreeting();">

Mind you, Jeremy may have given you a piece of good advice without realizing it; you would be far better off to generate the greeting line using server-side HTML. It would work across all browsers and SE spiders and everyone would see it.

Jeremy, I'd give you positive TP for that thought pattern you triggered, but I gotta find other people to give it to first. So I owe you one.

**Padawan Geek** · 04-14-2007, 01:06 AM

Quote:

Originally Posted by JeremyMiller

Well, you don't call other files, you can include them, but that'd be best done using PHP to minimize the overhead of loading the javascript. You could then call all appropriate functions. For example, in a PHP file you may have the following

PHP Code:


			
 <?php
   if (whatever you want) {
    echo "<script src=\"my_file.js\" type=\"text/javascript\" ></script>\n";
   }
 ?>
window.onload = pageLoader;
function pageLoader() {
  construction();
  timegreeting();
<?php
  if (whatever you want) {
    echo "my_function();\n";
  }
?>
}

Where my_function() is defined in my_file.js

You've lost me

... I have no experience in PHP so I have no idea what to do with that. Eek.