Hi ,

I have the below function that s not exactly running correctly

function amendHiddenLinks(linkDrag) { 
   document.getElementById('check').innerHTML = document.getElementById('links').value + "<BR>";
   obj =  linkDrag;        // get the parent 
   CN  =  obj.childNodes;  // get nodes
   x   =  0;               // loop variable
   document.getElementById('links').value = "";
   while(x < CN.length){	  
     
	   document.getElementById('links').value +=  CN[x].getAttribute('value') + "||";  	   
       x++;	
	  
   }
    document.getElementById('check').innerHTML = document.getElementById('links').value + "<BR>";
  
}

My problem is that CN[x].getAttribute('value') which is picking up the <li>.value is returning the first numeric only, ...... IF a numeric exists in the string.

IE <li value="link name"> WORKS FINE & returns "link name"
<li value="link 1 name"> FAIL & returns "1"
<li value="link na99me"> FAIL & returns 99
<li value="link 99 past the 10 15, 1"> FAILS & returns 99

Any ideas would be much appreciated. Been buggin me all day lol

It's probably because the value attribute for a li element should be a positive integer only.

And deprecated since HTML4 BTW

Thats understandable although how is ""link 1 name" interpreted as anything other than a string or even a negative number?

read your question and your examples the answer should be fairly apparent

it is selecting up to the last numeric if it exists (or the closing quote)

Just put numbers in there (as they should be) and it will probably work as expected.

Im sorry i am not with you.

This eg comes from a form where client adds links.

field 1 is link name
field 2 is link url

When the client enters "link 1", link is removed and the number 1 is left iun the string.

Because this is part of a drag and drop, i haev be able to strore this name/value pair in the li

Same with other chr numeric combinations.

You say "read your questions and examples" and things should be apparent, lol. I am sorry but it isn't

also : "Just put numbers in there (as they should be) and it will probably work as expected."
----- i don't want to input just numebrs. I require the client to enter a link url name which may be a combination of numeric and chr.

Any more ideas would be helpful.

You say "read your questions and examples" and things should be apparent, lol. I am sorry but it isn't

From post#4
it is selecting up to the last numeric if it exists (or the closing quote)

----- i don't want to input just numebrs. I require the client to enter a link url name which may be a combination of numeric and chr.

Obviously you can't do this with the value attribute and a <li> element. Unless you ensure the format of the inserted value is always

value="[name][number]"

with a optional space between name & number.
Even then don't try to validate the page code because it will fail.


2 possible choices that I can see;

1/ add an attribute of your own into the element.

2/ use a different attribute (title would be my choice)

Oh Thats Great Input.
Thanks very much. Ill get back to you if works using another attribute

Thats wicked thankyou!
I used a different attricbute ( title ) and everything is working a treat.
Thanks