JavaScript Forum

**Guerrilla** · 05:13 PM

Hey guys,

In the middle of writing a form validation script but the final alert message i want to use isnt showing. if you lok at the code you will see the one i mean. What have i done wrong?

HTML Code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Untitled Document</title>
</head>

<body>
<script type="text/javascript">

function validateThis(obj){
	// form fields to check
	var fieldRequired = Array("name", "email", "phone");
	// text for alert box if field is empty
	var fieldDescription = Array("Your Name", "Your Email", "Your Phone Number");
	// add the default text of your form
	var defaultText = "empty";
	// The beginning of the alert dialogue if fields are empty, keep \n at the end to preserve formatting
	var alertMsg = "Please complete the following fields\n";
	// loop through each field in fieldRequired and make an alert box to show the information	
    for (var i = 0; i < obj.length; i++){
	// alert("The " + fieldRequired[i] + "is " + obj.elements[fieldRequired[i]].value); // debugging to run through each required value
		if (obj.elements[fieldRequired[i]].value == "" || obj.elements[fieldRequired[i]].value == defaultText){
			alert(fieldRequired[i] + " isn't set");  //debugging to check fields not set
			//alertMsg += "test";
			}
		else {
			alert(fieldRequired[i] + " has been set");
		}	
	} 
	alert("this alert doesnt get displayed");
}

</script>

<form name="myForm"  onsubmit="return validateThis(document.myForm);" >
  <p>Name: 
    <input name="name" type="text" id="name" />
</p>
  <p>Phone: 
    <input name="phone" type="text" id="phone" />
  </p>
  <p>Email:
    <input name="email" type="text" id="email" />
  </p>
  <p>
    <input type="submit" name="Submit" value="Submit"  />
</p>
</form>


</body>
</html>

**Guerrilla** · 07-21-2007, 02:17 PM

i found out becase the script was erroring out when it come to the submit value in the form array. It says that it is not set. Not sure how I am going to get round it just yet :S

**Guerrilla** · 07-22-2007, 10:37 AM

fixed it with some help from another forum, script is finished now

**xprmnt** · 07-22-2007, 12:08 PM

Just a sidenote,
alert(argument) with an empty argument won't appear for some browsers,
I forget which ones ....

**Guerrilla** · 07-22-2007, 04:05 PM

thanks xpr, i'll keep an eye out for that. The problem was that the for loop was erroring out. I was passing the whole form object to the loop and when it got to the "submit" field it had no data so the script errored and exited before it got to the alert box. This was fixed by checking if each element had been set first.