JavaScript Forum

**69me** · 07-31-2007, 05:26 AM

hello

i have a problem, the following code works okay.

Code:

function showhidetextBox()
{
selectedValue = document.getElementById("Sport_Type").value;
if (selectedValue == "Multisports Tour")
document.getElementById("Which_Multitour").style.display = "";
else
document.getElementById("Which_Multitour").style.display = "none";
 }

but if i try and add an additional document.getElementById (like below) I get errors. Can anyone see why?

Code:

function showhidetextBox()
{
selectedValue = document.getElementById("Sport_Type").value;
if (selectedValue == "Multisports Tour")
document.getElementById("Which_Multitour").style.display = ""
document.getElementById("Which_Multitour").value = "Please Specify";
else
document.getElementById("Which_Multitour").style.display = "none";
 }

Thanks in advance!

Paul

**tripy** · 07:38 AM

An if/else blocks works without delimiter, but in that case only the first line is taken in account.

Your error is that as you have 2 lines in the if() block, the else is considered as an orphan by the scripting engine.

Rewrite it like:

Code:

if (selectedValue == "Multisports Tour"){
  //You may prefer to set the display to "block", to ensure that it's visible.
  //Your syntax here means "fall back on the style specified inline", and might be a problem if you update your html
  document.getElementById("Which_Multitour").style.display = ""; 
  document.getElementById("Which_Multitour").value = "Please Specify";
}
else{
  document.getElementById("Which_Multitour").style.display = "none";
}