Hi guys,

I'm having some issues with some very slow code at this site - http://www.blotanical.com/php/express.php

PHP Code:


$query = 'SELECT bfeed, blogRSS, bAdded FROM tblBlog WHERE bfeed = 1 AND bAdded=1 AND bPicks=0';
$result=mysql_query($query);
$num=mysql_numrows($result);

$urls = Array();

for ($n = 0; $n < $num-1; $n++) {

    $blogRSS=mysql_result($result,$n,"blogRSS");
    
        $urls[]=$blogRSS;
}         

$items = array();

// loop thru all urls & merge feeds into master array
foreach ( $urls as $url ) {
    $rss = fetch_rss($url);
    if (!$rss) continue;
    $items = array_merge($items, $rss->items);
    
}

// sort all items in array by date
usort($items, 'date_cmp');

// generate ouput array
$out = array();

foreach ($items as $item) {
    $href    = $item['link'];
    $title    = mysql_real_escape_string(stripslashes($item['title']));
    $desc =  strip_tags(summary($item['description'],35),'');
    $pubdate = date('D, j M Y',strtotime($item['pubdate']));
    
    $out[] = '<div id="repost"><h3>'.$title.'</h3><h4 style="color:#ece8de;line-height:0.8px; padding-left:5px">'.$pubdate.'</h4><p>'.$desc.'</p><a href="express_pick.php?action=display&id='.$href.'&nme='.$title.'" " title="'.$title.'">[Read more]</a></div><br /> ';
}

if (count($out) > MAX_ITEMS)
    $out = array_slice($out,0,MAX_ITEMS);

echo ($out)
 
    /*    ? "<ul>\n".join("\n",$out)."\n</ul>"*/
    ? join("\n",$out)
    
    : ''; 


blogRSS has been Indexed.
</strong>

I'm sure looping through a number of rss urls and using php to connect to each one and wait for output response would take up most of the time. It would be ideal to use some type of caching system to try to streamline this process.

I would recommend some form of a cron to download the file required, then put that into the file (via include).

I cant really add anything more, looks like some pretty clean code, whats your particular issues with it?

Dan, if you check out the URL you'll notice how incredibly long it takes to load.

Cheers Rogem002. I'll start having a fiddle with that idea.

Hey Rogem002. Cheers mate - it worked and it's so quick.

However, I have a new problem and that is because I have the cron file as an include it prints this line at the top of the page: #!/usr/local/bin/php -q

Any ideas on hiding this? I'm not sure how to comment it out as I can't use either PHP or HTML to do it.

i just said i couldnt think of a way to speed it up other than what the other said ¬.¬ and i just re-checked it out and its still slow as hell

Could you just skip the first line when printing it?
eg start iterating at 1 instead of 0.

Originally Posted by scrobins

Hey Rogem002. Cheers mate - it worked and it's so quick.

However, I have a new problem and that is because I have the cron file as an include it prints this line at the top of the page: #!/usr/local/bin/php -q

Any ideas on hiding this? I'm not sure how to comment it out as I can't use either PHP or HTML to do it.

It's needed I'm afraid, tells the server to run it like a PHP file. Make the CRON write the details to a file then include the file it wrote

Cache the page within a certain time interval so that it will automaticly recache the page as html depending on the time interval.

I don't know exactly what you want to do but id say if you want it to be fast you could try to change your query to get your data already in order and with a limit. The only thing that could slow the process is your loops.

it would look like this :

$query = 'SELECT bfeed, blogRSS, bAdded FROM tblBlog WHERE bfeed = 1 AND bAdded=1 AND bPicks=0 ORDER by `date_cmp` LIMIT MAX_ITEMS ';