okay some issues been a while since i wrote php or been on this site for that matter.

I am working on a login system for my users and my while clause is failing and the way the page is templated wont display an error if i put

PHP Code:

or die(mysql_error()) 


at the end of it here is the snippet

PHP Code:


$res = "SELECT * FROM users WHERE usrnm='". $usr ."'";
$subres = mysql_query($res) or die('FAIL1');
while($usrtst = mysql_fetch_array( $subres ) or die('FAIL2')) {
        if($pwd == !$usrtst['pwd']){
            echo '<form method="post" action="/scripts/doLogin.php">
           <div align="center" class="style69">
             <p>Quick Login:<br />
               Username<br />
                   <input name="username" type="text" id="username" />
                     <br />
               <strong><font color="#FF0000">Password is Invalid </font></strong><br />
               <input name="password" type="password" id="password" />
               <br />
               <input type="submit" name="Submit" value="Submit" />
               <br />
               <input name="remberme" type="checkbox" id="remberme" value="yes" />
             Remember Me </p>
             </div>
        </form> ';
        } 


though testing i found it was this line failing (notice or die('FAIL2')) yet this script works on my login processor so i dont know were i am going wrong, as this script is checking a cookie for a user name and password, check the username against the db, then validates if the pass is correct or not if it is then continues and if it fails then it redisplays the form with bold red font face to indicate a bad password in the cookie (ie someone spoofed or tampered it)

hope that helps with details thanks in advance for the help

figuered it out by doing some more research in to mysql commands for php

i changed this

PHP Code:

while($usrtst = mysql_fetch_array( $subres ) or die('FAIL2')) { 


to this

PHP Code:

while($usrtst = mysql_fetch_row( $subres )) { 


Um nevermind didnt work, forgot to test completly and it failed.... AGAIN...

I think it's missing a '}'. You are closing the if, but not the while.

Hi, this my first post

figured it out, finally

my dumb self had set the db user and password vars the same as the vars called from the cookie but had the require_once listing after calling the vars, so instead of using the vars from the cookie it used the vars from the config file, so i changed the config file to use different vars so instead of $usr i changed it to $dbusr.

works now

you are storing an user/password in a cookie !!!???
NAUGHTY !!!!!

Originally Posted by tripy

you are storing an user/password in a cookie !!!???
NAUGHTY !!!!!

He's right... thats a bad idea.

the password is only stored if the user checks remberme then when it is stored in the cookie it is stored in its MD5 state and the cookies are set to expire in 8 hrs

the connection between server is https and it is on an internal, i will rewrite the login to require users to enter the password everytime the site is loaded in to the browser after i am done making it, as it would be annoying everytime i close the browser (accidently or on purpose) to reenter the password esp if the page dont load correctly or i am debugging it.