Having a lot of trouble with my script. I am running a paid to click site and I am trying to contact my members. Unfortunately, I get this error:

Warning: mail(): Bad parameters to mail() function, mail not sent. in /control/mail.php on line 42

That message shows up 6 times.

Any help is greatly appreciated. Thank you!

The reason it occurs 6 times is because that is how many people it is trying to send it to - at least I figured that out!

Does anybody know why this would happen?

It would have because you sent bad parameters to the mail() function. If you want a more definitive answer, you have to give us something to work with, maybe some of the code?

Most likely you have one of the following:
1. Incorrect parameters
2. Too many parameters
3. Too few parameters

Can you send us the code your using?

Thanks all! Going to be gone for most of the day but I will check this later tonight. Also, I know next to nothing about script, but I have heard that this is horribly written (I got it from someone else). Thanks again in advance.

From my understanding, this is line42 which is having the problems: (complete code listed below)

PHP Code:

mail($a1[0], $subject, $message, $mailheaders); 


PHP Code:

<?

include('includes/header.php');
include('../includes/data_conn.php');

if(isset($submit))
{
    if(empty($who))
    {
    echo "<center><br><br><br> You did not choose the emails recipient.<br> Go <a class=TN href=mail.php> back </a> and make your choice. </center>";
    exit;
    }
    if(empty($message))
    {
    echo "<center><br><br><br> You are trying to send blank email. <br> Go <a class=TN href=mail.php> back </a> and write some text. </center>";
    exit;
    }
     if($_POST[who] == 'members')
     {
    $q1 = "select email from users ";
    $r1 = mysql_query($q1) or die(mysql_error());
     }
     elseif($_POST[who] == 'advertisers')
     {
    $q1 = "select email from newl ";
    $r1 = mysql_query($q1) or die(mysql_error());
     }

    while($a1 = mysql_fetch_array($r1))
    {
    
    $get_general = mysql_query("SELECT * FROM main");
                $grow = mysql_fetch_array($get_general);
                $g_title = $grow[title];
                $g_baseurl = $grow[baseurl];
                $g_aemail = $grow[adminemail];
                $g_newsemail = $grow[newsemail];
                
        $mailheaders = "From: " .$g_newsemail. "\n\n";
        $mailheaders .= "Reply-To: " .$g_newsemail. "\n"; 
        $mailheaders .= "Content-Type: text/plain; charset=\"ISO-8859-1\"\n";
    mail($a1[0], $subject, $message, $mailheaders);
    }
    echo "<center><br><br><br>The mail was sent successfully. </center>";
    unset($who);
    exit;
}
?> 
<div align="center"><br>
  <strong><font size="2" face="Arial, Helvetica, sans-serif">Email Members</font></strong><br>
</div>
<form action=<?=$PHP_SELF?> method=post>
  <table align=center width=550>
    <tr> 
      <td><font size="2" face="Arial, Helvetica, sans-serif"> Send emails to all: 
        </font></td>
      <td> <select name=who>
          <option value="">Select </option>
          <option value="members">Members </option>
          <option value="advertisers">Advertisers </option>
        </select> </td>
    </tr>
    <tr> 
      <td><font size="2" face="Arial, Helvetica, sans-serif">Subject: </font></td>
      <td><input type=text name=subject></td>
    </tr>
    <tr> 
      <td valign=top><font size="2" face="Arial, Helvetica, sans-serif">Message: 
        </font></td>
      <td><textarea rows=6 cols=45 name=message></textarea></td>
    </tr>
    <tr> 
      <td colspan=2 align=center> <input type=submit name=submit value=Send> </td>
    </tr>
  </table>
</form>

Apart form the fact that that isn't well coded in terms of readability, it seems your main problem is that you have declared $subject. Or message, at least I can't see where you have.

PHP Code:

mail($a1[0], $_POST[subject], $_POST[message], $mailheaders); 


Having said that, the line if(empty($message)) seems to be working fine, even though $message hasn't been declared. Oh well.

p.s. You need an apostrophe in email(')s.<br> won't validate also. You want <br /> actually, most of the above won't validate. Oh and <center> is deprecated.

from php.net : Multiple extra headers should be separated with a CRLF (\r\n).

in this case: $mailheaders ---> change \n\n and \n to \r\n

Thanks for the help guys, I'll take a look at all of this and let you know!

Those changes worked! I have a few other problems, but they are not directly related to the mail() function. Would you guys be interested in offering input with those as well? If not I can make a new post.

Thanks again!!

Try me. I'm always interested in these things, especially when there's Talkupation in it!

Thanks btw for the last lot.