hi,

on my file manager im just doing the rename func, how can i check if the name is valid?

file_exists() ?

nope i needed it to see if a string would be valid.

i have done it now using regex [a-zA-Z1-9_-]

This should help:

PHP Code:

$sanitized_name = preg_replace('/[^0-9a-z\.\_\-]/i','',$original_name);
if ($sanitized_name == $original_name) {
  echo "Great file name!";
} else {
  echo "Filename problems.  Try ".$sanitized_name;
} 


that looks better than what im using but could u just explain what the regex is doing not quite sure i get the 0-9 and a-z (shouldnt it also have A-Z for caps?) but whats the /i???

It replaces everything which is not a 0-9 a-z - _ or . case-insensitively (the i at the end).

Thanks i get what u mean now

Hi again,

This i causing errors

imysing this:

PHP Code:

if(empty($newname) && $sanitized_name == $newname)
{
 if(rename(DOC_ROOT.''.$cur_dir.'/'.$file, DOC_ROOT.''.$cur_dir.$newname))
 {
 echo '<script type="text/javascript"> window.location = "'.SITE_URL.'/admin/file_manager.php?dir='.$cur_dir.'" </script>';
 }
 else {
 echo '<script type="text/javascript">
      alert("ERROR: the file does not appear to have been successfully renamed! - Contact Admin");
  window.location = "'.SITE_URL.'/admin/file_manager.php?dir='.$cur_dir.'";
  </script>';
  }
}
else {
 echo "<script>alert('Filename problems.  Try ".$sanitized_name."');</script>";  
} 


and it seems to be the preg_replace and regex which is causing it, it always return false, and the stanistized name is empty. so i think somethings wrong

it seems it removes all valud chars,

so should i have if($sanitized !== '') so if there was any chars it didnt remove then i know its a bad name?

Can we see the code where the regex is applied?

figured it out, it was this:

PHP Code:

 
if(empty($newname) && $sanitized_name == $newname) 


</SPAN></SPAN>

it need a !before the empty() so it was reading false.

Dan

Good catch! Glad you got it figured out.

God i wish someone (hint hint) would fix that bug!! its peeving me off! when u have code it continues the colour and shows </span>'s GRR