PHP Forum

**Sharon_leic** · 10:33 AM

I placed this question in this php part as it might be more related to php if that makes sense

i have the below line

PHP Code:


			
echo "<a href='im/private.php?".$rnp['login']."'target=_new>"."<img src='siteimages/im.jpg' border='0' alt='Private message'></a><br>";

that nicely brings up a new window to private message someone in.

however i need the new popup to be a set size with scroll turned of and set dimentions, say 200x200

i know i can do it like this with javascript in html

<a href="javascript:windowHandle = window.open('private.php.html','Private message','width=200,height=200, location=yes'); windowHandle.focus()">Private</a>

but i can't work out how to use the script it in php without getting a parse error.

can anyone help me please?

Thanks

Shaz x

**pealo86** · 03-03-2008, 10:52 AM

Any code other than PHP, [e.g. html or javascript] would be entered as a string in PHP, just like normal text.

Well I think it should work with Javascript anyway, Ive only just started to learn it so I havent had the chance to mix it with PHP.

But I think so long as you just include it in the string it should work!

**Sharon_leic** · 03-03-2008, 10:57 AM

yeah javascript can be used in strings, i have used a fair bit of java in php on my site, its just this that refuses to work grrr

**tripy** · 03-03-2008, 11:42 AM

PHP Code:


			
echo <<<html

<script type="text/javascript">
function privateMsg(id){
  w=window.open('im/private.php?'+id,'winPrivateMsg','height=200,width=200')
}
</script>
<a href="privateMsg('{$rnp['login']}')"><img src='siteimages/im.jpg' border='0' alt='Private message'></a><br> 
html;

You can put the javascript function definition in another file (I even recommend you to).
Then, you simply call that javascript function in the href (or onclick) and you pass the value of your $rnp['login'] variable.

I've added single quotes around the output of the value, because if it's alphanumeric, then javascript will raise an error if it's not between signle or double quotes.
Maybe it's what happened to you before.

HTML Code:

href="function(35467);"  <!-- this is fine -->
href="function(going_34456);" <!-- but this is not -->
href="function('going_34456');" <!-- this is ok -->

**Sharon_leic** · 03-03-2008, 12:07 PM

aha i can see what you are saying although that code you wrote won't work for me

hmmmm maybe another bit of javascript on the same page might be interfering with it

**Sharon_leic** · 12:17 PM

when your code isn't in it my script works fine then if i add your code i get an error on the line after your code

this is the line of code i have after your script.. and its telling me there is an error in it

echo "<a href='viewprofile.php?".$rnp['login']."' target='_top'>".$rnp['login']."</a>";

error i am getting..
""Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in c:\wamp\www\friends.php on line 41""

**Sharon_leic** · 03-03-2008, 01:26 PM

I got it now thanks, and now know why my original way wouldn't work..

I had forgotton to close something else hehe

hanks again trippy

Shaz x

**tripy** · 03-03-2008, 01:48 PM

no problems

**Sharon_leic** · 03-03-2008, 02:17 PM

GRRRRRRRRRRRRRRRRR!

ok, this is my page cut down

Code:

<html>

<script type="text/javascript">
function private(id){
  w=window.open('im/private.php?'+id,'winPrivateMsg','height=340,width=337')
}
</script>

</html>


<?
$poo = "Sharon";


echo "<a href='javascript:private($poo)'><img src='siteimages/im.jpg' border='0' alt='Private message'></a><br>";
?>

when the image is clicked it returns the error ~ 'Sharon' is undefined ~

can you tell me how to call the function from within the php file with the right (varible) please

Thanks

Shaz x

**tripy** · 03:10 PM

You need to place single or double quotes if the parameter is alpha numeric:

PHP Code:


			
echo "<a href='javascript:private($poo)'><img src='siteimages/im.jpg' border='0' alt='Private message'></a><br>";

//should be
echo "<a href='javascript:private(\'$poo\')'><img src='siteimages/im.jpg' border='0' alt='Private message'></a><br>";

What you did is telling javascript that the variable was a return of a function named "Sharon()".
Putting quotes tells the javascript engine that "Sharon" is aliteral value, and not a reference to an javascript function or object.

**Sharon_leic** · 03-03-2008, 03:16 PM

Its now returning "error: invalid character" :-(

where "$poo" is, its there members name, it can only contain letters, numbers or underscore

**Sharon_leic** · 03-03-2008, 03:17 PM

got it got it! wooohoooooooooo hehe

this worked

Code:

echo "<a href='javascript:private(\"$poo\")'><img src='siteimages/im.jpg' border='0' alt='Private message'></a><br>";

thankyou so much for your help!
only took 2 days to do this bit hehe