PHP Forum

**Gilligan** · 03-08-2008, 08:22 PM

Sorry, this is urgent.

My contact form is not working, it keeps display my html code even though all the fields are filled in.

index.php

PHP Code:


			
<?php include ('/home/a5839198/public_html/inc/config.php'); ?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>SGilligan :: Contact</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link rel="stylesheet" type="text/css" href="../css/style.css">

</head>

<body><div id="main">

<div class="logo">
<?php echo $tagline ?>
</div>

<?php echo $nav ?>

<div class="content"><div class="box"><div class="title style1">Contact</div>
<p style="color:red; ">All fields required</p>
<form method="post" action="sendmail.php">

<!-- DO NOT change ANY of the php sections -->
<?php
$ipi = getenv("REMOTE_ADDR");
$httprefi = getenv ("HTTP_REFERER");
$httpagenti = getenv ("HTTP_USER_AGENT");
?>

<input type="hidden" name="ip" value="<?php echo $ipi ?>" >
<input type="hidden" name="httpref" value="<?php echo $httprefi ?>" >
<input type="hidden" name="httpagent" value="<?php echo $httpagenti ?>" >


Full Name:&nbsp;
<input type="text" name="visitor" size="35" >
<br ><br>
Your Email:&nbsp;
<input type="text" name="visitormail" size="35" >
<br ><br>
Subject:&nbsp;
<select name="attn" size="1">
<option selected>- - Select - -</option>
<option value=" New Project ">New Project</option>
<option value=" Technical Support ">Technical Support</option>
<option value=" General Query ">General Query</option>
</select>
<br ><br >
Message:
<br >
<textarea name="notes" rows="4" cols="40"></textarea>
<br >
<input type="submit" value="Send Mail" >

</form>
</div><div class="box2"><div class="title style1">Did You Know?</div>
<div class="iBox">This contact form was made by basic PHP, which is one of my coding skills. <a href="../about">See more...</a></div>
</div></div>

</div><?php echo $footer ?></body>
</html>

sendmail.php

PHP Code:


			
<?php include ('/home/a5839198/public_html/inc/config.php'); ?>

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
<html>
<head>
<title>SGilligan :: Home</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<link rel="stylesheet" type="text/css" href="../css/style.css">

</head>

<body><div id="main">

<div class="logo">
<?php echo $tagline ?>
</div>

<?php echo $nav ?>

<div class="content"><div class="box"><div class="title style1">Contact</div>

<?php

$ip = $_POST['ip'];
$httpref = $_POST['httpref'];
$httpagent = $_POST['httpagent'];
$visitor = $_POST['visitor'];
$visitormail = $_POST['visitormail'];
$notes = $_POST['notes'];
$attn = $_POST['attn'];


if (eregi('http:', $notes)) {
die ("Do NOT try that! ! ");
}
if(!$visitormail == "" && (!strstr($visitormail,"@") || !strstr($visitormail,".")))
{
echo "<h2>Use Back - Enter valid e-mail</h2>\n";
$badinput = "<h2>Feedback was NOT submitted</h2>\n";
echo $badinput;
die ("Go back! ! ");
}

if(empty($visitor) || empty($visitormail) || empty($notes) || $attn='- - Select - -') {
echo '<p class="error">Please fill in all fields</p>';
die ('<form method="post" action="sendmail.php">

<input type="hidden" name="ip" value="<?php echo $ipi ?>" >
<input type="hidden" name="httpref" value="<?php echo $httprefi ?>" >
<input type="hidden" name="httpagent" value="<?php echo $httpagenti ?>" >


Full Name:&nbsp;
<input type="text" name="visitor" size="35" >
<br ><br>
Your Email:&nbsp;
<input type="text" name="visitormail" size="35" >
<br ><br>
Subject:&nbsp;
<select name="attn" size="1">
<option selected>- - Select - -</option>
<option value=" New Project ">New Project</option>
<option value=" Technical Support ">Technical Support</option>
<option value=" General Query ">General Query</option>
</select>
<br ><br >
Message:
<br >
<textarea name="notes" rows="4" cols="40"></textarea>
<br >
<input type="submit" value="Send Mail" >

</form></div><div class="box2"><div class="title style1">Did You Know?</div>
<div class="iBox">This contact form was made by basic PHP, which is one of my coding skills. <a href="../about">See more...</a></div></div></div>

</div></body></html>');
}

date_default_timezone_set('GMT');

$todayis = date("l, F j, Y, G:i a") ;

$attn = $attn ;
$subject = $attn;

$notes = stripcslashes($notes);

$message = " $todayis \n
Attention: $attn \n
Message: $notes \n
From: $visitor ($visitormail)\n
Additional Info : IP = $ip \n
Browser Info: $httpagent \n
Referral : $httpref \n
";

$from = "From: $visitormail\r\n";


mail("info@sgilligan.co.uk", $subject, $message, $from);

?>

<p align="center">
Thank You <?php echo $visitor ?>,<br><br>Your email has been sent. 

</p>
</div><div class="box2"><div class="title style1">Did You Know?</div>
<div class="iBox">This contact form was made by basic PHP, which is one of my coding skills. <a href="../about">See more...</a></div></div></div>

</div></body>
</body>
</html>

Why won't this work?

**dansgalaxy** · 03-08-2008, 08:34 PM

Sorry im a little confused what u mean it shos your code?

can is see it live?

**Gilligan** · 03-09-2008, 06:41 AM

It just shows 'Fill in all fields'

http://www.sgilligan.co.uk/contact

**Sir P** · 03-09-2008, 08:05 AM

im looking at it now... i have given up on your server, host seems to time out 4 out of 5 attempts and its very slow when it does work - get on the phone to your host and give them an ear-bashing

anyway im running locally, I will tell you what i find..

**dansgalaxy** · 03-09-2008, 08:09 AM

Found it.

Your problem is here:

PHP Code:


			
|| $attn='- - Select - -'

you need == NOT = because this is ASSIGNING - - select - - to that variable and will ALWAYS return true causeing it to show the message.</SPAN>

Just change to double == and it should work.

Talkupation apprieciated

Dan

**Sir P** · 03-09-2008, 08:11 AM

OK spotted it!...

PHP Code:


			
if(empty($visitor) || empty($visitormail) || empty($notes) || $attn='- - Select - -')

In that statement you assign the variable $attn a value rather than checking it.... in PHP if you want to do equals then use == not =

So change that to ..

PHP Code:


			
if(empty($visitor) || empty($visitormail) || empty($notes) || $attn=='- - Select - -')

and it works perfectly.. I have tested it too.

Hope that helps

**Sir P** · 03-09-2008, 08:11 AM

oh dan.. a matter of seconds in front.. you post-sniped me good =]

**dansgalaxy** · 03-09-2008, 08:12 AM

*does a little dance*

Pure luck

**dansgalaxy** · 03-09-2008, 08:18 AM

Just to say Gilligan i LOVE the idea you have done on the portfollio page with the coding skills thing

**Gilligan** · 03-09-2008, 08:25 AM

Thanks alot! i knew this thing wasn't working for something simple

and thanks for the nice comment about my page