Have been using an nl2p function I found somewhere a while back for a long time however I've never really needed to use line breaks with it until now. Now when setting $line_breaks to true it doesn't return the <br's correctly.

It inserts the BR however it also snips off the first character of the line in the process.

Any suggestions?

PHP Code:

function nl2p($string, $line_breaks = true, $xml = false)
{
   // Remove existing HTML formatting to avoid double-wrapping things
    $string = str_replace(array('<p>', '</p>', '<br>', '<br />', "\r"), '', $string);
    
    // It is conceivable that people might still want single line-breaks
    // without breaking into a new paragraph.
    if ($line_breaks)
// ERROR IS IN THE FOLLOWING LINE SOMEWHERE
        return '<p>'.preg_replace(array('/([\n]{2,})/i', '/([^>])\n([^<])/i'), array("</p>\n<p>", '<br />'), trim($string)).'</p>';
    else 
        return '<p>'.preg_replace('/([\n]{1,})/i', "</p>\n<p>", trim($string)).'</p>';
} 


bump..

I regret to.. bump.

How newbie of me. And the solution is:

PHP Code:

function nl2p($string)
{
    $string = "<p>" . $string . "</p>";
    $string = preg_replace("/\r\n\r\n/", "</p>\n\n<p>", $string);
    $string = preg_replace("/\r\n/", "<br />", $string);
    return $string;
} 


Would probably easier to use nl2br() http://us.php.net/nl2br

Thanks for sharing your solution Rich.

Caleb: He's not tring to create <br />'s, but <p></p> surrounding things where there are 2 newlines and <br />'s where there is only 1 newline, so a bit more is needed. That said, $string = preg_replace("/\r\n/", "<br />", $string); could be replaced with nl2br b/c it occurs after the double newline replacement code.

Hey, wait a minute:

PHP Code:

$string = preg_replace("/\r\n\r\n/", "</p>\n\n<p>", $string);
$string = preg_replace("/\r\n/", "<br />", $string); 


Just thinking here. But, the first line quoted above inserts 2 newlines between paragraph closing and opening. the second then replaces those newlines with <br />'s (amongst other newlines). That seems flawed.

Perhaps what you want to do is format the source code w/o a visual change there? If so, then first replacing double newlines with </p><p>, then replacing the single newlines, and then replace </p><p> with the newlines added between?

Perhaps I misunderstand the point. I've been watching this thread from the beginning, just could figure out fully what you wanted to do and reading the initial reg exs confused me.

Works fine for me.

Hello\r\n\r\nHow are you?\r\nNot bad!

Becomes

<p>Hello</p>

<p>How are you?<br />
Not bad!</p>