Hi,

I making a web site and i have a code but this is not working properly dont knw why help me code is bellow

################################################## ############
JAVA SCRIPT

<script type="text/javascript">

if (document.images) {
image0 = new Image;
image1 = new Image;
image2 = new Image;

image0.src = "<?= $im_array[0] ?>";
image1.src = "<?= $im_array[1] ?>";
image2.src = "<?= $im_array[2] ?>";

} else {
image0 = '';
image1 = '';
image2 = '';
document.rollimg = '';
}
</script>

#################################

PHP CODE

<?= "<span onmouseover=document.rollimg.src=image0.src;>
<img src=\"../cars_images/$im_array[0]\" class=thumb_img width=150 height=150 alt=1\">
</span> " ?>
<?= "<span onmouseover=document.rollimg.src=image1.src;>
<img src=\"../cars_images/$im_array[1]\" class=thumb_img width=150 height=150 alt=2\">
</span>" ?>
<?= "<span onmouseover=document.rollimg.src=image2.src;>
<img src=\"../cars_images/$im_array[2]\" class=thumb_img width=150 height=150 alt=3\">
</span>" ?>

</p>
<p align="center">
<?=
"<img src=\"../cars_images/$im_array[0]\" class=thumb_img width=150 height=150 alt=Larger version of one of the smaller images above name=rollimg\">"
?>
</p>

######################################

Well, it's quit logical your code doesn't work!
The main issue is in your (X)HTML: wrong use of quotation marks for attributes.

This should work a bit better:

<p>
<?= '<span onmouseover="document.rollimg.src=image0.src;">
<img src="../cars_images/' . $im_array[0] . '" class="thumb_img" width="150" height="150" alt="1" />
</span>'; ?>
<?= '<span onmouseover="document.rollimg.src=image1.src;">
<img src="../cars_images/' . $im_array[1] . '" class="thumb_img" width="150" height="150" alt="2" />
</span>'; ?>
<?= '<span onmouseover="document.rollimg.src=image2.src;">
<img src="../cars_images/' . $im_array[2] . '" class="thumb_img" width="150" height="150" alt="3" />
</span>'; ?>

</p>
<p align="center">
<?=
'<img src="../cars_images/' . $im_array[0] . '" class="thumb_img" width="150" height="150" alt="Larger version of one of the smaller images above" name="rollimg" />';
?>
</p>

What I changed:

• single quotes for PHP, double quotes in (x)HTML (much more clear)
• ALL (x)HTML attributes begin and end with a quotation mark now
• The array-variables are placed outside the PHP strings
• Maybe not required in HTML, but ending slash in img-elements