Hey,

I am writing a bad words filter but it is not filtering any bad words. Can anyone help?

function filter($string) {
$badwords=file("badwords.txt");
for ($i=0;$i < count($badwords);$i++){
$string = str_replace($badwords[$i],str_repeat("*",strlen($badwords[$i])),$string);
}
return $string;
} 

$comments = filter($comments);

Thanks,
Matt

It does not work because file() returns an array of strings where each string ends with a newline character. Obviously your input text does not contain a newline after aech bad word. You should trim() each line of your txt file either right after file() or before str_replace().

But I would better use preg_replace() because it gives you much much more flexibility.

I have 1 bad word per line in the text file. The code is still not filtering out the bad words with a * per character. Any suggestions.

I am using the following code:

$er=0;

function filter($comments) {
$badwords=file("badwords.txt");
for ($i=0;$i < count($badwords);$i++){
$comments = preg_replace(trim($badwords[$i]),str_repeat("*",strlen($badwords[$i])),$comments);
}
return $comments;
} 
if ($er=0) { $comments=filter($comments);}

Are you trying to extend the code from http://www.webmaster-talk.com/php-fo...ds-filter.html ?

Anyway,

PHP Code:

$comments = preg_replace(trim($badwords[$i]),str_repeat("*",strlen($badwords[$i])),$comments); 


should be

PHP Code:

$comments = preg_replace('/'.preg_quote(trim($badwords[$i]),'/').'/i',str_repeat("*",strlen($badwords[$i])),$comments); 


Though your modifications are a bit less efficient than your earlier thread.

OMG

PHP Code:

    $badwords = array('bad', 'word');

    $comments = "this is a bad phrase that has bad, very bad words";

    echo $comments."\n";

    foreach ($badwords as $bw) {
        $comments = preg_replace("!\b{$bw}\b!", str_repeat("*",strlen($bw)), $comments);
    }

    echo $comments."\n"; 


You did not set delimiter for the regular expression (two exclamation marks in my case, but you can use any characters like / / or @ @). Also look at \b modifiers which mean "match only word boundaries" so that "badminton" or "sword" stayed untouched.