Hey,

I am having troubles allowing other image types to be allowed for upload on my site.
(www.YouHost.vndv.com)

Only type that can be uploaded right now is .GIF. Can anyone tell me what is wrong with the coding for it now allowing others?

Heres my code for the upload:

PHP Code:

<?php
if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/bmp")
|| ($_FILES["file"]["type"] == "image/png")
|| ($_FILES["file"]["type"] == "image/jpg")
|| ($_FILES["file"]["type"] == "image/pjpeg"))
&& ($_FILES["file"]["size"] < 20000))
  {
  if ($_FILES["file"]["error"] > 0)
    {
    echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
    }
  else
    {
    echo "Upload: " . $_FILES["file"]["name"] . "<br />";
    echo "Type: " . $_FILES["file"]["type"] . "<br />";
    echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
    echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";    if (file_exists("upload/" . $_FILES["file"]["name"]))
      {
      echo $_FILES["file"]["name"] . " already exists. ";
      }
    else
      {
      move_uploaded_file($_FILES["file"]["tmp_name"],
      "uploads/" . $_FILES["file"]["name"]);
      echo "URL: " . "www.YouHost.vndv.com/uploads/" . $_FILES["file"]["name"];
      }
    }
  }
else
  {
  echo "Sorry, an error occurred. Your File was either a format that we do not currently host or the file was larger than 20,000kb.";
  }
?>

i believe using the || is creating the problem. I believe that the || will approve any image as long as it matches those types listed above. So, you should remove the other entries.

Because the section is checking whether it matches one of those data types, once it has it checks size. Removing those unwanted datatypes will solve the problem.

I took out what you said and then it gave me an error and then i put them back in and then it worked. But said i tried to upload the wrong type. Only image I can upload is GIF, how I make it for all images. If I take off the image restriction, people can upload anything and thats a security risk.

This ($_FILES["file"]["size"] < 20000) is file size under 20000 bytes not Kb. Your average jpeg will be in excess of 19kb

So what should I put in the size spot? I set it higher and it now works. Thanks!

P.S. I thought your avatar was a bug on my screen and i tried to kill it ^_^

Originally Posted by GamingFreak

So what should I put in the size spot? I set it higher and it now works. Thanks!

P.S. I thought your avatar was a bug on my screen and i tried to kill it ^_^

me too... i miss read what you requested!

I thought you wanted on gif to be an option. LOL