PHP Code:

require ("config.php");
$timeoutseconds = 10; // length of session
$timestamp=time();
$timeout=$timestamp-$timeoutseconds;

   $query = mysql_query("SELECT ip FROM useronline WHERE timestamp<$timeout");
   while($row = mysql_fetch_array($query)){
   mysql_query("DELETE FROM users WHERE ip='".$row['ip']."'") or die(mysql_error());
} 


please help! mysql_query("DELETE FROM users WHERE ip='".$row['ip']."'") isn't deleting anything or giving any mysql errors

What are the errors your receiving?

From what I know, you cannot do a MySQL query into a query (In this case, the while() bit). Try the following:

PHP Code:

require ("config.php");
$timeoutseconds = 10; // length of session
$timestamp=time();
$timeout=$timestamp-$timeoutseconds;

   $query = mysql_query("SELECT ip FROM useronline WHERE timestamp<$timeout");
   while($row = mysql_fetch_array($query)){
      $ips_to_remove[] = $row['ip']; // Store the IP.
      //mysql_query("DELETE FROM users WHERE ip='".$row['ip']."'") or die(mysql_error());
   } 
 
foreach($ips_to_remove as $value){ // Do the query here one after the other.
      mysql_query("DELETE FROM users WHERE ip='".$value."'") or die(mysql_error());
      usleep(5000000); // Wait 5 seconds, this stops you over loading your server.
} 


Invalid argument supplied for foreach()

is there a way to get the IPs into an array to fix that or is there another solution to this problem?

Originally Posted by MoForce

PHP Code:

require ("config.php");
$timeoutseconds = 10; // length of session
$timestamp=time();
$timeout=$timestamp-$timeoutseconds;

   $query = mysql_query("SELECT ip FROM useronline WHERE timestamp<$timeout");
   while($row = mysql_fetch_array($query)){
   mysql_query("DELETE FROM users WHERE ip='".$row['ip']."'") or die(mysql_error());
} 


please help! mysql_query("DELETE FROM users WHERE ip='".$row['ip']."'") isn't deleting anything or giving any mysql errors

Maybe the DELETE query was never running. You should echo your DELETE query to see if it is finding what you want. Is the mySQL timestamp field in the same format that the $timeout variable is?

Originally Posted by CouponGuy

Maybe the DELETE query was never running. You should echo your DELETE query to see if it is finding what you want. Is the mySQL timestamp field in the same format that the $timeout variable is?

I echoed the query and it comes out perfect. I've found another way out of this problem that doesn't involve a query inside a query which does what I wanted to. Although, I still want to know if a mysql_query within a mysql_query is still possible and if so how? It would save a bunch of lines of code and would be awesome to use. Thanks for the help guys.

Yes, putting mysql queries inside a while loop should work. Also, you could put the query inside the same sql statement (I'm guessing you may have done this already).

SQL:

DELETE FROM users where ip IN (
   SELECT ip FROM useronline WHERE timestamp<$timeout
)

Originally Posted by MoForce

is there a way to get the IPs into an array to fix that or is there another solution to this problem?

That would suggest to me, that their are no IP's to delete. *Adds debugger

PHP Code:

require ("config.php");
$timeoutseconds = 10; // length of session
$timestamp=time();
$timeout=$timestamp-$timeoutseconds;

   $query = mysql_query("SELECT ip FROM useronline WHERE timestamp<$timeout");
   while($row = mysql_fetch_array($query)){
      $ips_to_remove[] = $row['ip']; // Store the IP.
      //mysql_query("DELETE FROM users WHERE ip='".$row['ip']."'") or die(mysql_error());
   } 
 
if(is_array($ips_to_remove ){foreach($ips_to_remove as $value){ // Do the query here one after the other.
      mysql_query("DELETE FROM users WHERE ip='".$value."'") or die(mysql_error());
      usleep(5000000); // Wait 5 seconds, this stops you over loading your server.
}} else {echo "Nothing to remove.";} 


Originally Posted by CouponGuy

Yes, putting mysql queries inside a while loop should work. Also, you could put the query inside the same sql statement (I'm guessing you may have done this already).

SQL:

DELETE FROM users where ip IN (
   SELECT ip FROM useronline WHERE timestamp<$timeout
)

I was thinking that, but the details are in different tables.