Hi all,

I am trying to write a script that will update numerous entries of the same field. In this case the credits of peoples accounts. The thing is i'm not entirely sure if this would work, i've tested it and it came up blank so I must have done something wrong.

Here's the code:

PHP Code:

<?php

include 'db.php';

$id = 1;

while($id < 201){

$get = mysql_query("SELECT * FROM members WHERE id='$id'");
$credit = mysql_fetch_array($get['credits']);
$credits = $credit + 100;

$sql = mysql_query("UPDATE members SET credits='$credits' WHERE id='$id'") or die (mysql_error());

$id = $id + 1;
}

if(!$sql){
echo 'Error';
}else{
echo 'Complete';
include 'test.html';
}
?>

Thanks,

Manson

Declare $sql outside of the while loop. It is a matter of scope in that you declare $sql nowhere until inside the while loop -- therefore, as far as PHP is concerned, that is the only place it exists. The way it is written now, your check if(!$sql) pass because $sql at that point is null. Also, even if you had declared $sql above the while loop, when you check it in the end, it will contain only the value of the very last loop iteration.

I am not sure why you are getting a blank screen, but you may want to start with a smaller set of data to update (perhaps all the id's under 5) and put some debug regarding the value of each $sql.

Instead of $id = $id + 1; Would it be better to use $i++ ??

Im not sure the correct syntaxes for it though


Lothop