So what I want when I echo my rows from the DB is to break a <tr> every 4 rows

Example:

<table>
<tr>
<td>A</td>
<td>B</td>
<td>C</td>
<td>D</td>
</tr>
<tr>
<td>E</td>
<td>F</td>
<td>G</td>
<td>H</td>
</tr>
</table>

What I have

PHP Code:

$query = mysql_query("SELECT * FROM users") or die(mysql_error()); 
while ($row = mysql_fetch_array($query)){
echo '<td>'.$row['name'].'</td>';";
} 


This should do it.

PHP Code:

$i = 0;
while (...) {
   echo '<td>' . $row['name'] . '</td>';
   if ($i++ == 4) {
      $i = 0;
      echo '</tr><tr>';
   }
} 


Shows 5 rows across, What I want is 4.

| 1 | 2 | 3 | 4 |

Simple fix,

PHP Code:

if ($i++ == 3){ 


Does what I wanted it to now. Thanks.

Originally Posted by Aaron™

Simple fix,

PHP Code:

if ($i++ == 3){ 


It may work, but that is terrible syntax. When you look at a line of code you should have an idea of what it does. Does that mean when i is equal to 4 do what is in the body of the if statement, or when it is 3? In a month from now looking back at this code will you be able to tell?

Since you reset i before referencing it again after that line of code, there is no reason to increment it.

Originally Posted by NullPointer

Does that mean when i is equal to 4 do what is in the body of the if statement, or when it is 3? In a month from now looking back at this code will you be able to tell?

Yes, I will.
($i++ == 4) will first compare $i to 4, and then increment $i. However, of course it should have been 3 instead of 4, as Aaron pointed out.

I guess your looking for something like this instead Matt, in order to not do one increase more than necessary?

PHP Code:

$i = 0;
while (...) {
   echo '<td>' . $row['name'] . '</td>';
   if ($i == 3) {
      $i = 0;
      echo '</tr><tr>';
   } else {
      $i++;
   }
}