PHP Forum

**sith717** · 11-02-2009, 01:19 PM

I am getting this error with a script:

Code:

Parse error: syntax error, unexpected T_IF in /home/brian/public_html/pages.php on line 5

PHP Code:


			
<?php
// Connects to your Database
include("inc/config.php");(
//This checks to see if there is a page number. If not, it will set it to page 1
if (!(isset($pagenum)))
{
$pagenum = 1;
}

//Here we count the number of results
//Edit $data to be your query
$data = mysql_query("SELECT * FROM accounts") or die(mysql_error());
$rows = mysql_num_rows($data);

//This is the number of results displayed per page
$page_rows = 4;

//This tells us the page number of our last page
$last = ceil($rows/$page_rows);

//this makes sure the page number isn't below one, or more than our maximum pages
if ($pagenum < 1)
{
$pagenum = 1;
}
elseif ($pagenum > $last)
{
$pagenum = $last;
}

//This sets the range to display in our query
$max = 'limit ' .($pagenum - 1) * $page_rows .',' .$page_rows; 

//This is your query again, the same one... the only difference is we add $max into it
$data_p = mysql_query("SELECT * FROM accounts $max") or die(mysql_error());

//This is where you display your query results
while($info = mysql_fetch_array( $data_p ))
{
Print $info['Name'];
echo "<br>";
}
echo "<p>";

// This shows the user what page they are on, and the total number of pages
echo " --Page $pagenum of $last-- <p>";

// First we check if we are on page one. If we are then we don't need a link to the previous page or the first page so we do nothing. If we aren't then we generate links to the first page, and to the previous page.
if ($pagenum == 1)
{
}
else
{
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=1'> <<-First</a> ";
echo " ";
$previous = $pagenum-1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$previous'> <-Previous</a> ";
}

//just a spacer
echo " ---- ";

//This does the same as above, only checking if we are on the last page, and then generating the Next and Last links
if ($pagenum == $last)
{
}
else {
$next = $pagenum+1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$next'>Next -></a> ";
echo " ";
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$last'>Last ->></a> ";
}
?>

Anyone know why?

This is the structure of my table:

Code:

+---------+------------+-----------+
| Table Name: accounts             |
+---------+------------+-----------+
|    id   |  username  |  password |
+---------+------------+-----------+
|       1 | john12     | thepass   |
|       2 | catman17   | cat       |
+---------+------------+-----------+

**diymonkey** · 11-02-2009, 01:25 PM

Yes, remove the open bracket on line 3:

include("inc/config.php");(

**sith717** · 11-02-2009, 01:31 PM

I have fixed it:

PHP Code:


			
<?php
error_reporting(E_ALL);
ini_set('display_errors', '1');
include("inc/config.php");
if (!(isset($pagenum)));
{
$pagenum = 1;
}
$data = mysql_query("SELECT * FROM accounts") or die(mysql_error());
$rows = mysql_num_rows($data);
$page_rows = 4;
$last = ceil($rows/$page_rows);
if ($pagenum < 1)
{
$pagenum = 1;
}
elseif ($pagenum > $last)
{
$pagenum = $last;
}
$max = 'limit ' .($pagenum - 1) * $page_rows .',' .$page_rows; 
$data_p = mysql_query("SELECT * FROM accounts $max") or die(mysql_error());
while($info = mysql_fetch_array( $data_p ))
{
Print $info['username'];
Print $info['password'];
echo "<br>";
}
echo "<p>";
echo " --Page $pagenum of $last-- <p>";
if ($pagenum == 1)
{
}
else
{
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=1'> <<-First</a> ";
echo " ";
$previous = $pagenum-1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$previous'> <-Previous</a> ";
}
echo " ---- ";
if ($pagenum == $last)
{
}
else {
$next = $pagenum+1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$next'>Next -></a> ";
echo " ";
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$last'>Last ->></a> ";
}
?>

Now for some reason it is not going to the next page.

It is only showing the first 4 rows and it wont show the rest when I click the next or last button.

**chieina** · 11-02-2009, 02:16 PM

do a requery... add "LIMIT" on your sql statement.

**sith717** · 11-02-2009, 02:28 PM

Can you show me how?

Like show me where I need to add a limit and stuff.

**sith717** · 11-02-2009, 04:02 PM

Thanks its fixed now:

PHP Code:


			
<?php
error_reporting(E_ALL);
ini_set('display_errors', '1');
include("inc/config.php");

$pagenum = (isset($_GET['pagenum'])) ? (int) $_GET['pagenum'] : 1;

$data = mysql_query("SELECT * FROM accounts") or die(mysql_error());
$rows = mysql_num_rows($data);
$page_rows = 4;
$last = ceil($rows/$page_rows);
if ($pagenum < 1)
{
$pagenum = 1;
}
elseif ($pagenum > $last)
{
$pagenum = $last;
}
$max = 'limit ' .($pagenum - 1) * $page_rows .',' .$page_rows;
$data_p = mysql_query("SELECT * FROM accounts $max") or die(mysql_error());
while($info = mysql_fetch_array( $data_p ))
{
echo "Username: ";
Print $info['username'];
echo "<br>";
echo "Password: ";
Print $info['password'];
echo "<br>----";
echo "<br>";
}
echo "<p>";
echo " --Page $pagenum of $last-- <p>";
if ($pagenum == 1)
{
}
else
{
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=1'> <<-First</a> ";
echo " ";
$previous = $pagenum-1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$previous'> <-Previous</a> ";
}
echo " ---- ";
if ($pagenum == $last)
{
}
else {
$next = $pagenum+1;
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$next'>Next -></a> ";
echo " ";
echo " <a href='{$_SERVER['PHP_SELF']}?pagenum=$last'>Last ->></a> ";
}
?>

----

Now I need help with another thing, How would I do it so instead of it posting it like this when im at the first page:

---- Next -> Last ->>

To like this:

| 1 | 2 | 3| Last ->>

Like it adds a number based on how many pages, its like instead of using the Next -> thing clicking over and over again to get to like page 5.

Same thing with the rest of the pages:

<<-First | 1 | 2 | 3| Last ->>

And the last page:

<<-First | 1 | 2 | 3|

Does anyone know how to do this? I want number pages instead of clicking to get to the next page or the page before.

**lizciz** · 11-02-2009, 04:24 PM

Run a query to find out how many rows there are (SELECT count(*) FROM table) and divide by the number of rows per page. Then add 1 to make the page numbers go from 1 to (n+1) instead of from 0 to n.

Print out the numbers as links using the loop of your choice (for, while, do-while).

**sith717** · 11-02-2009, 04:35 PM

How would I do that? Can you show me a code to do that? and maybe integrate it into my script? I would be very happy.

I also got this quote from another person:

Quote:

consider using LIMIT and OFFSET

LIMIT=5, OFFSET=10 (show 5 records, starting from the 10th)

increment offset by LIMIT each time.

As for the URLs, divide the total number of rows by the amount you want to show on each page (100records/20 per page==5 pages)

then do a loop

PHP Code:


			
$offset=0;
for($i=1;$i<=5;$i++) { echo '<a href="?offset='.$offset . '">'.$i.</a>;
$offset=$offset+20; //20=data per page
}
// do query

But have no idea how to implement that into my coding.

**lizciz** · 11-02-2009, 05:33 PM

I havn't looked at your code at all, but it shouldn't be that hard to integrate it. Something like this would work.

PHP Code:


			
// define rows per page and current page (if you havn't already)
$rowsPerPage = 10;
$currentPage = $_GET['page'];
$offset = 5;  // Number of pages to display at each side of the current page

$query = "SELECT count(*) FROM your_table";
$result = mysql_query($query);
$count = mysql_result($result, 0);

$nbrOfPages = ($count / $rowsPerPage) + ($count % $rowsPerPage > 0 ? 1 : 0);
/* If reminder when dividing, add another page. Example:
   $count = 10;
   $nbrOfPages = (10 / 10) + (10 % 10 > 0 ? 1 : 0) =
                 = 1 + (0 > 0 ? 1 : 0)
                 = 1 + 0 = 1 page

   $count = 13;
   $nbrOfPages = (13 / 10) + (13 % 10 > 0 ? 1 : 0) =
                 = 1 + (3 > 0 ? 1 : 0)
                 = 1 + 1 = 2 pages

*/

if ($currentPage > 1) {
   echo '<a href="yoursite.php?page=1">&lt;&lt; First page</a> ';
}
$start = $currentPage - $offset;
$end = $currentPage + $offset;
if ($start < 1) {
   $start = 1;
}
if ($end > $nbrOfPages) {
   $end = $nbrOfPages;
}
for($i = $start; $i <= $end; $i++) {
   if ($i = $currentPage) {
      echo " <b>$i<b/> ";
   } else {
      echo ' <a href="yoursite.php?page=' . $i . '">' . $i . '</a> ';
   }
}
if ($currentPage < $nbrOfPages) {
   echo ' <a href="yoursite.php?page=' . $nbrOfPages . '">Last page &gt;&gt;</a>';
}

**sith717** · 11-02-2009, 06:59 PM

Can you integrate that into my script? I have no idea where to add that too.

**lizciz** · 11-03-2009, 12:48 AM

Try adding it where you want the page links to appear.