I am receiving the following error from a Joomla plugin (Rokkin Gallery) and can not seem to get any help from the developer.

Warning: Division by zero in /home/rugby/public_html/components/com_rokin/extensions/ext_rokin_photo.php on line 18

How do I fix this??

Stop dividing by zero. If you want more help, we'll need to see the code.

This is not that hard.
As I see you have been trying to divide by zero. To change this you can ex. try to use an 'if' expression on the parameters

But try to link your ext_rokin_photo.php file, and I'll try to fix it if you want ^^

Yep, dividing by zero is actually runtime error.

Sorry...here's the code:

<?php
if(!(defined('_VALID_MOS') || defined( '_JEXEC' ))){
die( 'Restricted access' );
}

/* simple xml for php4 */
$simpe_xml_native =true;
if(!function_exists("simplexml_load_file")){
require_once "administrator/components/com_pwframework/classes/class.simplexml.php";
function simplexml_load_file($file){
$sx = new simplexml;
return $sx->xml_load_file($file);
}
$simpe_xml_native =false;
}


/* make this configurabel */
require_once("administrator/components/com_pwframework/lib/joomla.support.php");

require_once("administrator/components/com_rokin/lib/rokin.common.php");
loadFrameWork();
require_once("administrator/components/com_rokin/lib/classdef.php");
require_once 'administrator/components/com_rokin/lib/classloader.php';
require_once 'administrator/components/com_rokin/lib/picasa_api.php';

//get the correct class file
if(isJoomlaOne()){
require_once("administrator/components/com_rokin/rokin.j10.class.php");
}else{
require_once("administrator/components/com_rokin/rokin.j15.class.php");
}


/*================================================= ========================= */
?>

<style>
table .pw-template{
width: 100%;
}
table .pw-template td{
/*border:1px solid #cccccc;*/

border-spacing: 2px;
}
</style>

<?php
/* loading the rokin specific settings */
$database = getDBase();
$setting = new rokinSetting($database);
$setting->loadById(1);

if(isset($setting->description)){
echo "<p>" . $setting->description ."</p>";
}

$command = new crudcommand();
$GLOBALS['command'] = $command;
$command->optionUrlTag = "unit";
$command->actionUrlTag = "act";
$command->preNavUrl = "index1.php?option=com_rokin&Itemid=" . getReqParamVal('Itemid');
$command->newCommand("gallery", new commandAction("show","Gallery", -1, null, array("Itemid","gid")));
$command->newCommand("album", new commandAction("show","Album", -1, null, array("Itemid","albumid")));
$command->newCommand("photo", new commandAction("show","Photo", -1, null, array("Itemdid","albumid","photoid","photoindex")) );


$rokinRequest = get_rokin_request();
plugins_pre();

echo "<table cellpadding=\"1\" cellspacing=\"1\" class=\"pw-template\" >";

$extensionsTopMost = get_active_subs_per_position(POSITION_TOP_MOST, $rokinRequest->stage);
$extensionsTop = get_active_subs_per_position(POSITION_TOP, $rokinRequest->stage);
$extensionsLeft = get_active_subs_per_position(POSITION_LEFT, $rokinRequest->stage);
$extensionsRight = get_active_subs_per_position(POSITION_RIGHT, $rokinRequest->stage);
$extensionsBottom = get_active_subs_per_position(POSITION_BOTTOM, $rokinRequest->stage);
$extensionsBottomMost = get_active_subs_per_position(POSITION_BOTTOMMOST, $rokinRequest->stage);
$colspan = 1;
if(count($extensionsLeft) > 0){
$colspan++;
}
if(count($extensionsRight) > 0){
$colspan++;
}

if(count($extensionsTopMost)> 0){
echo "<tr><td colspan=\"$colspan\">";
foreach ($extensionsTopMost as $ext){
$ext->render($rokinRequest);
}
echo "</td></tr>";
}


if(count($extensionsTop)> 0){
echo "<tr><td colspan=\"$colspan\">";
foreach ($extensionsTop as $ext){
$ext->render($rokinRequest);
}
echo "</td></tr>";
}

if(count($extensionsLeft)> 0){
echo "<td valign=\"top\">";
foreach ($extensionsLeft as $ext){
$ext->render($rokinRequest);
}
echo "</td>";
}


echo "<td>";

// print_r($command);
// echo "<hr>";
// global $command; //reload from globals (php4 hack)
// print_r($command);
// echo $_REQUEST['unit'];
$command->run();
echo "</td>";

if(count($extensionsRight)> 0){
echo "<td valign=\"top\">";
foreach ($extensionsRight as $ext){
$ext->render($rokinRequest);
}
echo "</td></tr>";
}

if(count($extensionsBottom)> 0){
echo "<tr><td colspan=\"$colspan\">";
foreach ($extensionsBottom as $ext){
$ext->render($rokinRequest);
}
echo "</td></tr>";
}

if(count($extensionsBottomMost)> 0){
echo "<tr><td colspan=\"$colspan\">";
foreach ($extensionsBottomMost as $ext){
$ext->render($rokinRequest);
}
echo "</td></tr>";
}
echo "<tr><td colspan=\"$colspan\" >";
//echo "<span ><a style='font-size:6pt; margin-left; margin-right;color:#cccccc;' href='http://www.pageworks.nl'>PageWorks - RokinWeb Gallery ". getRokinVersion() . "</a></span>";
echo "</td></tr></table>";

plugins_post();


function plugins_pre(){
$rokinRequest = get_rokin_request();
$ext = get_plugings();
foreach ($ext as $e){
$e->renderPre($rokinRequest);
}
}
function plugins_post(){
$rokinRequest = get_rokin_request();
$ext = get_plugings();
foreach ($ext as $e){
$e->renderPost($rokinRequest);
}
}

/**
* initialisation function of the framework called as default
*
*/
function init(){
$Itemid = getReqParamVal("Itemid");
$Itemid = getReqParamVal("gid");
gallery_show($Itemid);
}


/* exectues the active gallery extension */
function gallery_show($Itemid, $gid=null){
$rokinRequest = get_rokin_request();
$ext = get_active_extension_per_stage(STAGE_GALLERY, STAGE_TYPE_EXT);
$ext[0]->render($rokinRequest);
}

/* exectues the active album extension */
function album_show($Itemid, $albumid){
$rokinRequest = get_rokin_request();
$ext = get_active_extension_per_stage(STAGE_ALBUM, STAGE_TYPE_EXT);
$ext[0]->render($rokinRequest);
}

/* executes the active photo extension */
function photo_show($Itemid, $albumid, $photoid){
$rokinRequest = get_rokin_request();
$ext = get_active_extension_per_stage(STAGE_PHOTO, STAGE_TYPE_EXT);
$ext[0]->render($rokinRequest);
}


?>

That code doesn't say much -.-
The error occurs in the file ext_rokin_photo.php, on line 18. Could you post that file? Or if it's big, just a couple of lines (line 18 included of course).

Yea, and can you please mark the text as php. Makes it easier to read ^^

Sorry about the previous code post. Too many hours in front of the monitor..Here's the real deal!

PHP Code:

<?php

if(!(defined('_VALID_MOS') || defined( '_JEXEC' ))){
    die( 'Restricted access' );
}

class ext_rokin_photo extends RokinStage{
    
function render($rokinRequest){
    /*load settings*/
    $database = getDBase();
    $setting = $this->loadSettings();
    $imgmax = getImageMax($setting->picture_size);

    $item = $rokinRequest->photo;
    
    /* load the selected item */
    $ratio = $item->img_width / $item->img_height;
    
    /* load gallery to retrieve sorting order */
    $gallery = $rokinRequest->gallery;
    
    /* determine next and previous */
    $items = load_rokin_album_items2($rokinRequest->albumid, $gallery->order);
    $total_pictures = count($items);
    for($i = 0; $i < $total_pictures; $i++){
        /* found, select next and previous */
        if($items[$i]->id_base==$rokinRequest->photoid){
            if($i==0){
                $prev = $total_pictures -1;                
            }else{
                $prev = $i - 1;
            }
            if($i== ($total_pictures -1)){
                $next = 0;
            }else{
                $next = $i + 1;
            }        
            break;    
        }
    }
    
    if(isDebug()){
        echo "next<br>";
        print_r($items[$next]);
        echo "prev<br>";
        print_r($items[$prev]);
    }
    
    /* cast to rokinitems */
    $next_item = new RokinItem($database);
    $next_item->cast($items[$next]);

    $prev_item = new RokinItem($database);
    $prev_item->cast($items[$prev]);
    
//    echo $ratio;
    if($item->img_width > $item->img_height){
        $height = $setting->picture_size / $ratio;
    }else{
        $height = $setting->picture_size;
    }
    ?>
    <table cellpadding="0" cellspacing="0"  class="album-detail" style="width:100%; margin:10px;">
        <tr><td></td><td align="center" style="text-align:center;"><div style="line-height:20px; color:white; font-weight: bold; font-size: 110%;padding-top:4px;"> <?php  echo ($i + 1) . " / " . $total_pictures ?></div></td><td></td></tr>
        <tr>
            <td width="70" align="center">                
                <a href="<?php echo $prev_item->getUrlForPhotoid($rokinRequest->Itemid); ?>">
                    <img src="<?php echo $this->extension_url; ?>/images/prev.gif" border="0">
                </a>
            </td>
            <td align="center" style="text-align: center;">
                <img src="<?php echo $item->img_base;?>?imgmax=<?php echo $imgmax;?>" height="<?php echo $height; ?>" title="<?php echo $this->title?>"  class="pwimages" border="0" />
            </td>
            <td width="70" align="center">
                <a href="<?php echo $next_item->getUrlForPhotoid($rokinRequest->Itemid); ?>">
                    <img src="<?php echo $this->extension_url; ?>/images/next.gif"  border="0">
                </a>
            </td>
        </tr>
    </table>
    <?php
 }
      

    
/**
     * this function renders the settings when you configure the extension
     *
     */
    function renderSettings($lang){
        $classLoader = new RokinClassLoader();
        $setting = $this->loadSettings();
        $myForm1 = new Composite();    
        $myForm1->value=$lang->gallery_settings;
        $myForm1->addElement(new JoomlaLabel($lang->picture_size, ""),new InputText("picture_size",  $setting->picture_size, "picture_size"));
        $myForm1->render();    
    }
    function storeSettings(){
        parent::storeSettings(array("picture_size"));
    }
    
    function loadSettings(){
        return parent::loadSettings(array("picture_size=640"));
    }
}
?>

Originally Posted by GrooN

Yea, and can you please mark the text as php. Makes it easier to read ^^

Here's how!
http://www.webmaster-talk.com/php-fo...st-my-php.html

The problem is on line 18 as the error writes ^^

heres a fix for it:

PHP Code:

if ($item->img_height > 0) // Checking that the img_height isn't zero
    $ratio = $item->img_width / $item->img_height;
else // if the img_height is zero
    somefunction_error_handling("divide by zero"); // function i made up, does not exist! 


I think the comments speak for themselves ^^

Been busy as all **** for a few days, so just now catching up, and doing some traveling the next few weeks...

As a suggestion, you may want to handle this better when fetching the image information:

PHP Code:

$rokinRequest->photo 


That bit of code is returning a zero value for img_height, so you'd actually do better to have some error checking wherever that attribute is defined... a try/catch routine where the image must exist and have a width and height each > 0. This will catch the error you'll find of dividing by $ratio when the width is 0.