Hello,

I have a bunch of If/Else statements in my PHP code, but they don't seem to be working. Here's the code:

PHP Code:

$input = array("blue","red","yellow","green","purple","orange","white","black","pink");
$rand_keys = array_rand($input, 2);
$confirmkey = $input[$rand_keys[1]] . "\n";

if ($confirmkey == "blue") {
$soundfile = "sounds/red.mp3";
}
else if ($confirmkey == "red") {
$soundfile = "sounds/blue.mp3";
}
else if ($confirmkey == "yellow") {
$soundfile = "sounds/green.mp3";
}
else if ($confirmkey == "green") {
$soundfile = "sounds/yellow.mp3";
}
else if ($confirmkey == "purple") {
$soundfile = "sounds/orange.mp3";
}
else if ($confirmkey == "orange") {
$soundfile = "sounds/purple.mp3";
}
else if ($confirmkey == "white") {
$soundfile = "sounds/black.mp3";
}
else if ($confirmkey == "black") {
$soundfile = "sounds/white.mp3";
}
else if ($confirmkey == "pink") {
$soundfile = "sounds/pink.mp3";
}
else {
$soundfile = "none";
}

echo $confirmkey;
echo "$soundfile"; 


Now you may be wondering; why the heck would I want to do that? Well, I want to confuse bots. They'll enter the wrong value in the box, and be rejected.

The problem is is that $soundfile is always 'none'. I really don't get why. A simple random function, then a bunch of If/Elses to determine a variable for the outcome.

Why does this happen?

Thanks,

-PG

$rand_keys = array_rand($input, 2)

have you tried changing the 2 to a 1? Not sure if that is it, but I think that number tells it to request that many items from the array.

Actually, I fixed it. Chrishirst can delete this thread now, problem solved .

I can't really remember what I did to fix it, I just played around with it a bit, and I think it turned out to be something completely different. Thanks, though!

probably using else if rather elseif (no space)

Using the switch statement is better than a lot of elseif statements

PHP Code:

switch($confirmkey) {
    case "blue" 
        $soundfile = "sounds/blue.mp3";
        break;
    case "red" 
        $soundfile = "sounds/red.mp3";
        break;
    case "yellow" 
        $soundfile = "sounds/yellow.mp3";
        break;
    case "green" 
        $soundfile = "sounds/green.mp3";
        break;
    case "purple" 
        $soundfile = "sounds/purple.mp3";
        break;
    case "orange" 
        $soundfile = "sounds/orange.mp3";
        break;
} 


And easier to follow & debug.

So glad you brought up the switch.

If the confirmkey matches the filename you could also use:

$soundfile = !empty($confirmkey) ? 'sounds/'.$confirmkey.'.mp3' : 'none';

Or with an array check:

$validkeys = array('blue','red','yellow',...);
$soundfile = !empty($confirmkey) && in_array($confirmkey, $validkeys) ? 'sounds/'.$confirmkey.'.mp3' : 'none';