PHP Forum

**silverglade** · 03-07-2010, 08:25 AM

hi. i want the user to choose one of the radio button selections, and mail me the results, its not working, i get back "blarg".

here is the html

Code:

<div align="center">
  <form id="form1" name="form1" method="post" action="userform1.php">
    <p>
  
        <input type="radio" name="RadioGroup1" value="five" id="five" />
        5 
   
   
      <input type="radio" name="RadioGroup1" value="ten" id="ten" />
      10 
 
   
        <input type="radio" name="RadioGroup1" value="fifteen" id="fifteen" />
        15 
 
    
        <input type="radio" name="RadioGroup1" value="twenty" id="twenty" />
        20 
   
     
        <input type="radio" name="RadioGroup1" value="twenty_five" id="twenty_five" />
        25 
  
   
        <input type="radio" name="RadioGroup1" value="thirty" id="thirty" />
        30 
    
    </p> 
    <input type="submit" name="submit " id="submit " value="submit" /> 
   
  </form>
</div>

here is the php

Code:

<?php 
if(isset($_POST['submit'])) { 
$to = "derekpainter1@hotmail.com"; 
$subject = "How many attributes to use on bossgrade.com";
foreach($_POST as $key => $value) {  /*loops through the POST array and uses the form values*/
  $$key = $value;
}
  
$body = "Feedback from user:  \n Number of attributes should be : $five \n  Number of attributes should be : $ten  \n   Number of attributes should be : $fifteen \n   Number of attributes should be : $twenty \n   Number of attributes should be : $twenty_five \n   Number of attributes should be : $thirty   \n "; 
  
echo "Thank you for filling out my feedback form!"; 
mail($to, $subject, $body); 
} else { 
echo "blarg!"; 
} 
?> 
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
<title>Feedback form</title>
</head>

<body>
</body>
</html>

**NullPointer** · 03-07-2010, 12:48 PM

Two things:

Code:

<input type="submit" name="submit " id="submit " value="submit" />

The trailing space in the name attribute is what is causing the problem. Remove it.

Also, read the mail() documentation carefully: http://us2.php.net/manual/en/function.mail.php

Even though the headers are an optional parameter, the from header is required. The only way it will work without including headers is if you specify a default from address in your php.ini

**silverglade** · 03-07-2010, 03:43 PM

awesome! thank you so much for that. i was waiting all day to get that fixed. so thank you. also, in my email, i wanted to be able to tell which radio button they pressed. but as it is coded now, all i get in my email is this

Feedback from user:
Number of attributes should be :
Number of attributes should be :
Number of attributes should be :
Number of attributes should be :
Number of attributes should be :
Number of attributes should be :

**MattGoucher** · 03-07-2010, 03:59 PM

You seem to be missing your mail headers. Most mail providers will not except mail that is not from anyone. Also you might need to specify a SMTP server. Heres how:

PHP Code:


			
mail($To, $Subject, $Body, $Headers);

Notice the headers. If you don't have them, your mail might not get sent. The simplest way to add headers for this issue would be like this:

PHP Code:


			
$Headers = "From: You@YourDomain.com";

Also, If you want more information on how to do this, check This out.

**NullPointer** · 04:09 PM

Your problem is here:

PHP Code:


			
foreach($_POST as $key => $value) {  /*loops through the POST array and uses the form values*/

  $$key = $value;

}

  

$body = "Feedback from user:  \n Number of attributes should be : $five \n  Number of attributes should be : $ten  \n   Number of attributes should be : $fifteen \n   Number of attributes should be : $twenty \n   Number of attributes should be : $twenty_five \n   Number of attributes should be : $thirty   \n ";

I'm not exactly sure what you are going for, but it looks like you are assuming PHP uses the id attribute of an input field as the key in POST data. It doesn't; it uses the name attribute. The value you are looking for is stored in the $RadioGroup1 variable.

Try:

PHP Code:


			
$body = "Feedback from user:  \n Number of attributes should be : " . $_POST['RadioGroup1'];

You should get rid of that for loop altogether. In general you shouldn't use the entire $_POST array to set variables without doing any checking.

**silverglade** · 03-07-2010, 04:20 PM

great thanks very much. that is much better. but i still get the following in my email. i cant tell which radio button they pressed. any more help greatly appreciated. thanks. derek

Feedback from user:
Number of attributes should be :
Number of attributes should be :
Number of attributes should be :
Number of attributes should be :
Number of attributes should be :
Number of attributes should be :

**NullPointer** · 03-07-2010, 04:22 PM

Are you sure you updated the code correctly?

PHP Code:


			
$body = "Feedback from user:  \n Number of attributes should be : " . $_POST['RadioGroup1'];

It looks like you are still using the old code.

**silverglade** · 03-07-2010, 04:27 PM

thank you so much nullpointer and mattgoucher!!! IT WORKS!! hahaha. it took me all day to get help for that. thank you so much for looking at my code and helping. it works! YAY! hehe. thanks. derek

**MattGoucher** · 03-07-2010, 04:49 PM

Haha, I hope I helped a bit. Congrats on your mail script. If you hadn't figured it out by now, I would have sent you mine