PHP Forum

**chronix** · 06-07-2010, 10:30 AM

For some reason a login script I've been using has suddenly decided to stop working. The script is being used in three locations. It has stopped working on my local server and on an external server. On the other external server it is working though. I have tried downloading the files from the working server to use on others but it won't work and rather than return the main page, it loops back to the login page.

Can anybody see what the problem might be?

Login.php:

Code:

<?php 
$TARGET = "/"; // go to this page if login ok
//SETUP, insert your users and passwords
$users = array("demo", "admin");
$passwords = array("demo_pass", "password");


session_start();
	if(isset($_GET['login'])){	
		for($i=0; $i!= sizeof($users); $i++){
			if($users[$i] == $_POST['username']){
				if($passwords[$i] == $_POST['password']){
					$_SESSION['login'] = true;
					header("location: ".$TARGET);
				}
			}
		}
		$msg = "An error occurred. Please try again.";
	}
?>









<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=ISO-8859-1" />
<title>Extranet</title>
<link href="/templates/Spectrum/master.css" rel="stylesheet" type="text/css" />
</head>

<body>

<div id="container">
  <div id="innerCont">
	
	
	<!-- // Spectrum // Begin main structure -->
	
	
	<div class="mastWarn">
	<h2>Protected Content</h2>
	<p>To access this content you must be a member of staff. Contact the Station Manager for login information.</p>
	</div>

	<div id="content">	
	
	<!-- // Spectrum // Page Content -->
	
	
	<form id="form1" name="form1" method="post" action="?login">
  <table width="370" border="0">
    
    <?php if(isset($msg)) echo "<tr>
      <td colspan=\"2\" class=\"error\">".$msg."</td>
    </tr>";?>
   
    
    <tr>
      <td width="175"><div align="right"><strong>Username:</strong></div></td>
      <td width="185"><label>
        <input type="text" name="username" value="demo"/>
      </label></td>
    </tr>
    <tr>
      <td><div align="right"><strong>Password:</strong></div></td>
      <td><label>
        <input type="password" name="password" value="demo_pass"/>
      </label></td>
    </tr>
    <tr>
      <td>&nbsp;</td>
      <td><label>
        <input type="submit" name="button" id="button" value="Login" />
      </label></td>
    </tr>
  </table>
</form>

<p>Testing Login<br /><br />Username: demo<br />Password: demo_pass
	<hr />


<!-- // Spectrum // End Page Content -->
    </div>
	<div id="footer"><hr /><p>&copy; 2009</p></div>
	
	<!-- // Spectrum // End main structure -->
	
	
  </div>
</div>

</body>
</html>

**Andy Pugh** · 06-08-2010, 06:39 AM

Hi Chronix,

Simple issue you're having here, you're stating - if(isset($_GET['login'])) { which isn't being set, change this is to

PHP Code:


			
 if(isset($_POST['username'])){

That'll do the trick for you.

Ta,
Andy

**chronix** · 06-09-2010, 06:47 AM

Quote:

Originally Posted by Andy Pugh

Hi Chronix,

Simple issue you're having here, you're stating - if(isset($_GET['login'])) { which isn't being set, change this is to

PHP Code:


			
 if(isset($_POST['username'])){

That'll do the trick for you.

Ta,
Andy

That didn't work. It also works perfectly find on one server but not the others so I can't understand why some of the code would need changing :s

**Phunk Rabbit** · 06-09-2010, 06:53 AM

Im fairly sure session_start() needs to be at the top of the file, you will also encounter issues with using headers in the middle of the script without using output buffering.

The headers will cause an error along the lines of ERROR: Headers already sent......