Hi i have coded a navigation so that it can have a sister level.

But unfortunately it doesnt close the <li> if there is no sister level so it looks like this

<ul>

  <li><a href="'">test link</a>

</ul>

Could someone help me solve this...

The actuall code is here:

PHP Code:


<ul>

<?php
//$query="SELECT * FROM staticpage";
//$res = mysql_query($query,$db);
//$row1 = mysql_fetch_array($res);
$query = "select * from staticpage where parent_id=0";
$res=mysql_query($query);
while($row = mysql_fetch_array($res))
{

?>
    <li><a href="<?php echo str_replace(" ", "-", strtolower($row['non_edit_name']))?>.php" title="<?php echo $row['name']?>"><?php echo $row['name']?></a>
<?php
$pqry="SELECT * FROM staticpage WHERE parent_id=".$row['id'];
$resp=mysql_query($pqry);
if(mysql_num_rows($resp) >0)
{
?>
            <ul>
<?      
while($rowp = mysql_fetch_array($resp))
{

?>
        <li><a href="<?php echo str_replace(" ", "-", strtolower($rowp['non_edit_name']))?>.php" title="<?php echo $row['name']?>"><?php echo $rowp['name']?></a></li>
<?
} 
?> 
            </ul>
          
          </li>
<?
}
}
?>


</ul>

Thanks in advance

It looks like you need to move the closing </li> outside of the body of the if statement.

Also using short tags (<?) is a bad habit. It makes your code less portable and they will be deprecated in future versions of PHP.

Originally Posted by NullPointer

It looks like you need to move the closing </li> outside of the body of the if statement.

Also using short tags (<?) is a bad habit. It makes your code less portable and they will be deprecated in future versions of PHP.

Thanks for the advice.

I will change the short code now

I will also check if thats what it is

It needed a <li> inside and outside

Also changed to long code rather than short hand.

Thanks