Hi,

I'm trying to create a script that a user can upload and image, it shows on a page as a thumb and then when clicked, it opens in a lightbox window.

I have most of it sorted, but the images do not seem to be resizing...

When uploaded, they stay the original size instead of making them smaller...


The script I'm using contains this:

PHP Code:



##############################################################################################
function imageResize($width, $height, $target) 
##############################################################################################
{
  //protect function if image sizes not set (i.e. image doesn't exist in database)
  if((!isset($width)) || (!isset($height)))
  { $width = '1'; $height = '1'; }
  //if trying to resize an image that is much smaller than target...essentially do nothing and keep the original sizing
  elseif(($width < $target) && ($height < $target))
  { }
  else
  {
    //takes the larger size of the width and height and applies the  formula accordingly...this is so this script will work dynamically with any size image
    if ($width > $height)
    { $percentage = ($target / $width); }
    else
    { $percentage = ($target / $height); }

    //gets the new value and applies the percentage, then rounds the value
    $width = round($width * $percentage);
    $height = round($height * $percentage);
  }
  
  //returns the new sizes in html image tag format...
  return "width=\"$width\" height=\"$height\"";
}//END - imageResize 


Any ideas or am I barking up the wrong tree with this particular part of the code?

you should resample image stream

You should use image magick with imagick libraries in php. Check if it's installed in your server, then it's easy like this:

$image_filename='my_pic.jpg';
$thumb_filename='my_thumb.jpg';

// set the thumbnail size
$x=100;
$y=100;

try {
$im = new Imagick($image_filename);
// make the thumbnail
$im->thumbnailImage($x, $y, true);
$im->writeImage($thumb_filename);
}
catch (Exception $e) {
//... put here your error catch code
}

Try this class. Just input the path to the source image and specify the destination dimensions to get the resized image. Very handy.

forgot to post the image uploder I'm using as well!

PHP Code:

##############################################################################################
function upload($user_id,$fileid)
##############################################################################################
{
  global $db;
  $maxsize = $_POST['MAX_FILE_SIZE'];
  if(is_uploaded_file($_FILES['userfile']['tmp_name'][$fileid])) 
  {
        if($_FILES['userfile']['size'][$fileid] < $maxsize)
        {
          $imgData = addslashes(file_get_contents($_FILES['userfile']['tmp_name'][$fileid]));
          $size = getimagesize($_FILES['userfile']['tmp_name'][$fileid]);
          
          $sql_query = "SELECT * FROM user_images WHERE image_id = '999999999999999999'";
                 
          if(mysqli_num_rows(mysqli_query($db, $sql_query)) > 0)
          {
            $sql_query = "UPDATE user_images SET image_type = '{$size['mime']}', image = '{$imgData}', image_size = '{$size[3]}', image_name = '{$_FILES['userfile']['name'][$fileid]}' WHERE image_id = '$user_id'";
          }
          else
          {
            $sql_query = "INSERT INTO user_images ( image_type ,image, image_size, image_name) VALUES ('{$size['mime']}', '{$imgData}', '{$size[3]}', '{$_FILES['userfile']['name'][$fileid]}')";
          }
          if(!mysqli_query($db,$sql_query)) { echo '<div class="error">Unable to upload file</div>'; }
          else { $return = mysqli_insert_id($db); }
        }
        else 
        {
          echo
          '<div>File exceeds the Maximum File limit.  Skipping uploading of image.</div>
          <div>Maximum File limit is '.$maxsize.'</div>
          <div>File '.$_FILES['userfile']['name'][$fileid].' is '.$_FILES['userfile']['size'][$fileid].' bytes</div>
          <hr />';
        }
  }
  return $return;
}//END - upload() 


This is driving me mad... is there anyway to edit the original code that I have?

When I start using other examples, it messes up all the function names on other pages...!

Here is an old bulletproof method I use, it's not a method but just a piece of code:

PHP Code:

//create empty image
$destimg=ImageCreateTrueColor($new_width,$new_height) or die('Problem In Creating image');

//create image from uploaded image $prod_img
$srcimg=ImageCreateFromJPEG($prod_img) or die('Problem In opening Source Image');

// the actual resize just copies the image from source to destination with new dimentions
@imagecopyresampled($destimg,$srcimg,0,0,0,0,$new_width,$new_height,ImageSX($srcimg),ImageSY($srcimg))
                   or die('Problem In resizing');

//save file with $new_name
ImageJPEG($destimg,$new name,90)or die('Problem In saving');

//kill temp image
imagedestroy($destimg); 


I get:

Parse error: syntax error, unexpected T_STRING

with the line being

PHP Code:

 ImageJPEG($destimg,$new name,90)or die('Problem In saving'); 


Originally Posted by rolda hayes

I get:

Parse error: syntax error, unexpected T_STRING

with the line being

PHP Code:

 ImageJPEG($destimg,$new name,90)or die('Problem In saving'); 


I'm guessing $new name should be $new_name.

Good job - that got rid of the error - NEXT..!!

PHP Code:

Warning: imagecreatetruecolor() [function.imagecreatetruecolor]: Invalid image dimensions in... 


If you're using the code nordedata posted you'll need to define some of the variables.

@nullpointer

I think this is where I'm getting lost with this.

Would it make more sense for the images to be resized to a set size (using nordedata's code) and then use my original code to just make the thumbs appear on the pages?

Same problem thanks for solutions