i'm new to php and i need some help, i made this for a site i'm making, but i get this error: Fatal error: Maximum execution time of 30 seconds exceeded in /home/b2l1366/public_html/t/fight.php on line 15 i know its probabaly something stupid but becasue i don't know much about php i'm not sure whats wrong

PHP Code:

<?php
session_start();
include "header.php";

//monster stats
$monsterhealth=10;
$monsterstrengh=5;
//player stats
$playerhealth=$get3[health];
$playerstrengh=$get3[strengh];

$set=1;
//fight time
while ($set>0){
while ($set==1 & $playerhealth>0){
$playerattack=rand(1,$playerstrengh);
$monsterhealth=$monsterhealth-$playerattack;
echo "You attack the $action, and do $playerattack damage, the $action has $monsterhealth  health left<br>";
if ($playerhealth<=0){
$set=0;
} else{
$set=2;
}
} while ($set==2 & $monsterhealth>0){
$monsterattack=rand(1,$monsterstrengh);
$playerhealth=$playerhealth-$monsterattack;
echo "The $action attacks you and does $monsterattack, you have $playerhealth health left";
if ($playerhealth<=0){
$set=0;
} else{
$set=1;
}
}
}

include "footer.php";
?>

Basically, one of your loops is never ending. You've made an infinite loop.

A few things you should fix, and that may (or may not) fix your problem.

1) Use && as the AND operator. & is the bitwise AND operator, and doesn't function the way you want it to (in your case).

2) This line:

PHP Code:

} while ($set==2 & $monsterhealth>0){ 


Should be split into two, like so:

PHP Code:

} 
while ($set==2 & $monsterhealth>0){ 


Don't close a loop and start one on the same line. The way you have it is the way you write the condition for a DO WHILE loop, when you're using a regular WHILE loop.

3) Indent your code! I don' know if it's just because you copy/pasted it or whatever, but if you don'T indent your code, make sure you do. Especially when using loops. Makes it a LOT easier to see what's going on.

4) When getting wariables using the $_GET superglobal, put the index name in '' (so $_GET['foo']), and capitalize the GET. It's just a standard practive to capitalize constants and system vars in this case.

5) You're starting a session at the top, but aren't setting any variables. Why's this?

Let me know if any of that helped (or didn't).


------------------------ FOOBAR EDIT -------------------------

I found the problem. In your first loop, you have the player attacking the monster. Thus, you should be checking the monsters health. Instead, you're checking the player health in your if statement.


------------------------ /FOOBAR EDIT -------------------------

3) Indent your code! I don' know if it's just because you copy/pasted it or whatever, but if you don'T indent your code, make sure you do. Especially when using loops. Makes it a LOT easier to see what's going on.

thanks for replying, i don't understand what you said above.
il see if your solution works tomorrow, i'm going to bed now

Originally Posted by timsquash5

thanks for replying, i don't understand what you said above.
il see if your solution works tomorrow, i'm going to bed now

He means make your code look like this:

PHP Code:

<?php
session_start();
include "header.php";

//monster stats
$monsterhealth=10;
$monsterstrengh=5;

//player stats
$playerhealth=$get3[health];
$playerstrengh=$get3[strengh];

$set=1;

//fight time
while ($set>0)
{
   while ($set==1 & $playerhealth>0)
   {
        $playerattack=rand(1,$playerstrengh);
        $monsterhealth=$monsterhealth-$playerattack;
        echo "You attack the $action, and do $playerattack damage, the $action has $monsterhealth  health left<br>";
      
        if ($playerhealth<=0)
       {
          $set=0;
       }
       else
       {
          $set=2;
       }
   } 

   while ($set==2 & $monsterhealth>0)
   {
        $monsterattack=rand(1,$monsterstrengh);
        $playerhealth=$playerhealth-$monsterattack;
        echo "The $action attacks you and does $monsterattack, you have $playerhealth health left";
        
        if ($playerhealth<=0)
       {
           $set=0;
       }
        else
       {
           $set=1;
       }
   }
}

include "footer.php";
?>

That way it's easy to see what's going on in a loop or if statement and also whether or not they are closed. Each coder has their own style, but the point is to make it human-readable. After all, if the syntax is correct, the parser can read it no matter how messy it is. But if there's a bug, YOU're the one who has to fix it, so YOU'd better be able to read it.