Hello,

I am using the following query:

mysql_query("UPDATE products SET products_quantity = products_quantity - ".$amount_bought.", products_status = IF (products_quantity - ".$amount_bought." < 1, 0, 1) WHERE products_model='".$model."'");

The problem is that products_status is set to 0, even if the remaining products_quantity is 1.


What did i do wrong?

thanks!

Matt

No idea, do we get to see the query rather than PHP code?

UPDATE products SET products_quantity = products_quantity - 1, products_status = IF (products_quantity - 1 < 1, 0, 1) WHERE products_model='ADO_AP Churchill'

How can a "less than one" match be true when the result is 1??

no idea what you mean, but if stock drops to 0 or less, status must be disabled.

then your query should be IF(criteria <= 0 ...) [less than OR equal to] ZERO

From your post ->

The problem is that products_status is set to 0, even if the remaining products_quantity is 1.

Your actual query was checking for the result being LESS THAN ONE which a result of 1 cannot be.

ok thanks will try that!

i now have this query:

UPDATE products SET products_quantity = products_quantity - 1, products_status = IF (products_quantity - 1 <= 0, 0, 1) WHERE products_model='AP Churchill'

But products_status is still set to 0 when the stock drops from 2 to 1.

Your query has already deducted 1 from quantity BEFORE the the IF is evaluated.

oh, thats how it works, ok didn't know that. I will try reversing both.

works now, thanks!

Hello,

Sorry to start this old thread again, but what if i want the update condition do nothing if the condition is false?

Right now
products_status = IF (products_quantity - 1 <= 0, 0, 1)

updates products_status to 0 if condition true, and to 1 if false.

But if false i want nothing to happen, how can i do that?

Thanks!

Matt

have nothing at all for the "false" codition

It seems to me that your information is reduntant. If you already have the quantity, why do you need another field to say if there are more items or not? The quantity field would be enough. Every time you check if the status field is 0 or 1, you could instead check if the quantity is 0 or >0, thereby eliminating the status field completely.

Originally Posted by lizciz

It seems to me that your information is reduntant. If you already have the quantity, why do you need another field to say if there are more items or not? The quantity field would be enough. Every time you check if the status field is 0 or 1, you could instead check if the quantity is 0 or >0, thereby eliminating the status field completely.

Status might be used for other things - eg adding a new range in advance of launch with a status indicating "don't publish in catalogue".