Hi Guys,

Bit of a problem on a page i'm trying to code. I am trying to get the code able to pull out rows of information from the database by using

while()....

Below is the code that i have, and as the title says; this is the error that i'm getting.

$mySQL = new mod_db();
$mySQL->connection();

$sql = "SELECT * FROM table WHERE userName = '$userName' AND password = '$password'";

if(!$mySQL->query($sql)) {
	echo "Unable to check data from table";
}
if($mySQL->nums($sql,'') == "0") {
	echo "<script>alert('Username / Password Incorrect');</script>"; // English Error Message   
	echo "<meta HTTP-EQUIV='REFRESH' content='0; url=http://www.website.co.uk/admin/'>";
             
} else {

    $result = $mySQL->query($sql);	
    while($row = $result->fetch_assoc())
    {
		$userID = $row['userID'];
		echo $userID;
	}

Thanks

I cannot see the error.
If you pasted well, you have a mising '}' at the end.

$result is not an object, which most likely means your query failed.

There are a couple of issues with your overall design as well. For one you are executing the query twice. Here:

PHP Code:

if(!$mySQL->query($sql)) 


and here:

PHP Code:

$result = $mySQL->query($sql); 


The other issues I see is here:

PHP Code:

if($mySQL->nums($sql,'') == "0") 


I have no idea what library you're using, but it seems like if you want to get the number of rows you would get it from a result resource, not a query string. Also, why are you quoting the zero? Technically it will still work, but it is poor coding.

Originally Posted by vectorialpx

If you pasted well, you have a mising '}' at the end.

If there were an issue with his syntax he would get a parse error.

Originally Posted by NullPointer

If there were an issue with his syntax he would get a parse error.

Like I said, I cannot see the error. I don't know if you see more than me but after the "this is the error that i'm getting" I can only see the code.
Anyway... it's good that you figure it out.

The error message is in the title of the post:

Call to a member function fetch_assoc() on a non-object

If there were a syntax error he would be getting a parse error before the code was even evaluated. So the fact that he is getting that message instead means his syntax is fine.

Thank you for the replies guys, I fixed it in the end.. Also thank you for the pointers in the coding, bits i need to iron out