$username = $row['username'];
$password = $row['password'];
$id = $row['id'];

if ($num==0) {
echo ("The database contains no record of your user or your password is incorrect."); 
} else {
setcookie("XingName", "$username");
setcookie("XingID", "$id");
mysql_close();
echo("<meta http-equiv=\"refresh\" content=\"0;URL=./?q=\">"); } 

} else { ?>

<form name="login" action="" method="post">
  <p>
    <input name="user" type="text" id="user">
</p>
  <p>
    <input name="pass" type="password" id="pass" value="">
</p>
  <p>
    <input type="submit" name="login" value="Submit">
    <input type="reset" name="Reset" value="Reset">
</p>
</form>

<? 

}

?>

^^ having a small problem with that code, when the user logs in.. it says "The database contains no record of your user or your password is incorrect."

The only time it says that is when the user does not exist or the password / username is incorrect... can anyone help why this is happening and not doing what its meant to?

Where is $num coming from? You are checking if( $num == 0 ), but your code does not show where $num gains its value. Also, you have two else clauses for only one if(), so there is clearly some more code preceeding this segment in the file. Post the whole file so we can get a better idea of what is going on.

thats the entire file, excluding the db connection... $num doesnt represent anything, i dont know what to put... thought it was

"$num=mysql_num_rows($result);" but it doesnt work

For that matter, where does $row come from? I'm guessing there is a database query happening somewhere, but that's not shown in your post.

<?

if (isset($_POST['login'])) {

$username = $_POST["user"];
$password = $_POST["pass"];

mysql_connect("localhost", "user", "password") or die( "Unable to connect to database");
@mysql_select_db("db") or die( "Unable to select database");

$query="SELECT * FROM users WHERE user='$username' AND pass = '$password'";
$result=mysql_query($query);

$username = $row['username'];
$password = $row['password'];
$id = $row['id'];

if ($num==0) {
echo ("The database contains no record of your user or your password is incorrect."); 
} else {
setcookie("XingName", "$username");
setcookie("XingID", "$id");
mysql_close();
echo("<meta http-equiv=\"refresh\" content=\"0;URL=./?q=\">"); } 

} else { ?>

<form name="login" action="" method="post">
  <p>
    <input name="user" type="text" id="user">
</p>
  <p>
    <input name="pass" type="password" id="pass" value="">
</p>
  <p>
    <input type="submit" name="login" value="Submit">
    <input type="reset" name="Reset" value="Reset">
</p>
</form>

<? 

}

?>

You are never calling mysql_fetch_array($result) to have $row assigned. I honestly don't know how your script is ever working. I don't know how you are not getting a syntax error with the additional else statement.

could you help then?

Kyrnt, if you look again you will see that the second else statement is for the first if. It is opened properly.

Try this...

PHP Code:

<?

if (isset($_POST['login'])) {

$username = $_POST["user"];
$password = $_POST["pass"];

mysql_connect("localhost", "user", "password") or die( "Unable to connect to database");
@mysql_select_db("db") or die( "Unable to select database");

$query="SELECT * FROM users WHERE user='$username' AND pass = '$password'";
$result=mysql_query($query);
$row = mysql_fetch_assoc($result);

$username = $row['username'];
$password = $row['password'];
$id = $row['id'];

if ($id==0) {
echo ("The database contains no record of your user or your password is incorrect."); 
} else {
setcookie("XingName", "$username");
setcookie("XingID", "$id");
mysql_close();
echo("<meta http-equiv=\"refresh\" content=\"0;URL=./?q=\">"); } 

} else { ?>

<form name="login" action="" method="post">
  <p>
    <input name="user" type="text" id="user">
</p>
  <p>
    <input name="pass" type="password" id="pass" value="">
</p>
  <p>
    <input type="submit" name="login" value="Submit">
    <input type="reset" name="Reset" value="Reset">
</p>
</form>

<? 

}

?>

Originally Posted by cptnwinky

Kyrnt, if you look again you will see that the second else statement is for the first if. It is opened properly.

Cptn, Aye, I see that in the new, more complete code. But it was missing in the original posting. Hopefully your listing will solve the issue.

Thanks.