nevermind

what you are doing now is just checking what it is called, and based on the url of the image.
This does nothing for checking if it is a valid image or not.

What you need to do is check the MIME TYPE of the image.

Well...that is all i want really i think, the thread title is probably misleading. Unless i misunderstood what you said.

All i want it to do is make sure what they enter into the 'Button URL' box ends in jpg, gif, bmp or png...

Anyone?

well i don't really know much about the preg_match function
what i would do
is use this
$pointies = explode($button);
$ext = $pointies[count($pointies)-1];
$ext = strtolower($ext);
For optimal security you could use mime types aswell. But never really sollely on mime types.
Pretty sure the above will work. Good luck!

I'm having some problems with a random affiliate script.
You know something about that?
http://www.webmaster-talk.com/showthread.php?t=27483

This should work to check for the MIME type:

PHP Code:

$arr=array(IMAGETYPE_GIF, IMAGETYPE_JPEG, IMAGETYPE_PNG, IMAGETYPE_BMP);

$valid = false;

foreach ($arr as $value)
{
  if(exif_imagetype($button) == $value) 
  {
    $valid = true;
  }
}
if($valid)
{
  // File is valid, carry on
}
else
{
  echo 'This is not a valid file';
  exit;
} 


What that does is make sure somebody doesn't take a .php file, or any other evil file, and just rename it to .jpg and upload it.

^^ Great thanks
However when a non valid file type is posted i just get a bunch of failed to open stream messages eg:

Warning: exif_imagetype(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(http://dfsdsdfsgf): failed to open stream: Success in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(http://dfsdsdfsgf): failed to open stream: Success in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(http://dfsdsdfsgf): failed to open stream: Success in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(): php_network_getaddresses: getaddrinfo failed: Name or service not known in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(http://dfsdsdfsgf): failed to open stream: Success in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Any idea how to rectify that?

Shouldn't be too hard to fix. Post your code if you can (especially around line 28, but preferably all of it).

nevermind

Okay, just change this:

PHP Code:

// Check if they entered a valid image.
$arr=array(IMAGETYPE_GIF, IMAGETYPE_JPEG, IMAGETYPE_PNG, IMAGETYPE_BMP);

$valid = false;

foreach ($arr as $value)
{
  if(exif_imagetype($button) == $value)
  {
    $valid = true;
  }
}
if($valid)
{
  // File is valid, carry on
}
else
{
  echo 'This is not a valid file';
  exit;
} 


To this:

PHP Code:

// Check if they entered a valid image.
$arr=array(IMAGETYPE_GIF, IMAGETYPE_JPEG, IMAGETYPE_PNG, IMAGETYPE_BMP);

$valid = false;

foreach ($arr as $value)
{
  if(exif_imagetype($button) == $value)
  {
    $valid = true;
  }
}
if(!$valid)
{
  echo 'Invalid file type.';
  exit;
} 


That's the easiest way to fix it. You can replace 'Invalid file type.' with the error message you want to give when it's invalid.

Same error messages

Warning: exif_imagetype(http://x2.putfile.com/3/8005355887.if): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(http://x2.putfile.com/3/8005355887.if): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(http://x2.putfile.com/3/8005355887.if): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in /home/starlet/public_html/plugboard/pboard/plug.php on line 28

Warning: exif_imagetype(http://x2.putfile.com/3/8005355887.if): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found in /home/starlet/public_html/plugboard/pboard/plug.php on line 28
Invalid file type.

Oh, I see they're just putting the button URL, I thought they were uploading the image... it probably won't work then, but I don't really know, somebody else here might know.

Checking whether it ends in jpg, gif or bmp is probably good enough.

aah right, no they just enter the url yeah.
Thanks for the help any way, much appreciated

code removed

Is it perhaps something to do with numbers? I've noticed if the button url has a number before the .ext then it works, otherwise it does not.