<?php
$username=$_POST['username'];
$username=trim($username);
$pass=$_POST['pass'];
$pass=trim($pass);

if (empty($username) || empty($pass))
{
echo "Please enter valid Username and Password";
exit;
}

if (!ereg("^[a-zA-z0-9]*$",$pass))
{
echo("password must contain only letters and numbers");
exit;
}
if (strlen($pass)!=8)
{
echo "Your password must be 8 characters long";
exit;
}


if (ereg("^s",$username))
{
$arrayuserpass=file("studentuserpass.txt");
for($i=0;$i<count($arrayuserpass);$i++)
{
$token=explode(",",$arrayuserpass[$i]);
$user=$token[0];
$psw=$token[1];
echo $username;
echo $user;
echo $pass;
echo $psw;

if ($username==$user)
{
if ($pass == $psw)
{
//$login="true";
echo "Login Sucessfull";
exit;
{
}
else
{
$login="false";
}
}
if ($login=="false")
{
echo "Username and Password not match";
}
}

?>




---- it keeps saying the password not match.. can someone help me. thanks

use echo $psw; and echo $pass; every time you change something to them and see where your problem is ...

i got this when testing your code:
error, unexpected T_ELSE in D:\c_webserver\htdocs\teste\Untitled.php on line 47
afetr i removed the extra "{" :
error, unexpected $end in D:\c_webserver\htdocs\teste\Untitled.php on line 58
added a } before the script ended and it seemed to work ...
replaced the _POST with _GET to test it .... : "Login Sucessfull" ...

hi there.. thanks for he quick replied. i need to use "POST" coz im getting the data from a file. thanks for help

the new php files after i made some changes

PHP Code:

<?php
    $username=$_POST['username'];
    $username=trim($username);
    $pass=$_POST['pass'];
    $pass=trim($pass);

    if (empty($username) || empty($pass))
    {
        echo "Please enter valid Username and Password";
        exit;
    }

    if (!ereg("^[a-zA-z0-9]*$",$pass))
    {
        echo("password must contain only letters and numbers");
        exit;
    }
    if (strlen($pass)!=8)
    {
        echo "Your password must be 8 characters long";
        exit;
    }


    if (ereg("^s",$username))
    {
        $arrayuserpass=file("studentuserpass.txt");
        for($i=0;$i<count($arrayuserpass);$i++)
        {
            $token=explode(",",$arrayuserpass[$i]);
            $user=$token[0];
            $psw=$token[1];
            echo $username;
            echo $user;
            echo $pass;
            echo $psw;

            if ($username==$user)
            {
                if ($pass == $psw)
                {
                    //$login="true";
                    echo "Login Sucessfull";
                    exit;
                }
            }
            else
            {
                $login="false";
            }
        }
        if ($login=="false")
        {
            echo "Username and Password not match";
        }
    }

?>

Just to point out that you can use the [php ] [/php ] tags (without the spaces) to get a nicely framed and syntax coloured version of your code like above.

xopetz: does it work now?

and by _POST and _GET i meant i replaced them when testing because i had no form and was lazy ... still if it worked with _GET it should work with _POST... (if you took care of the errors i posted above that is).

hi there..

the problem i had is the get doesnt work ( the password seems doesnt match ) i tried did what you explained above but still doesnt work. or i misunderstood what u were trying to say to me ? thanks for your help.

cheers

you don't have to use $_GET i used it only for testing.

anyway, i didn't seem to be able to explain myself to good so i made my best to find your bug.

seems to me " if (ereg("^s",$username)) " should be negated " if (!ereg("^s",$username)) "

that way i got a login succesfull.

One more thing...
Your regular expression has [a-zA-z0-9] when it SHOULD be [a-zA-Z0-9].

(That period is not a "special character" for the RegEx; merely the end of my sentence. :-P)

hi there. thanks for the help.
another thing is.

if ($username==$user)
{
if ($pass == $psw)
{
//$login="true";
echo "Login Sucessfull";
exit;
}
}
else
{
$login="false";
}
}


if ($pass == $psw) --> this line when i type the password correctly, it still return false. i dunno what happened. thanks


cheers,

i really have no clue why you say that it is not working, here are the files i tested them on. i had no problem whatsoever. check your form and your studentuserpass.txt please, your problem may lay there.


script.php :

PHP Code:

<?php
    $username=$_POST['username'];
    $username=trim($username);
    $pass=$_POST['pass'];
    $pass=trim($pass);

    if (empty($username) || empty($pass))
    {
        echo "Please enter valid Username and Password";
        exit;
    }

    if (!ereg("^[a-zA-z0-9]*$",$pass))
    {
        echo("password must contain only letters and numbers");
        exit;
    }
    if (strlen($pass)!=8)
    {
        echo "Your password must be 8 characters long";
        exit;
    }


    if (!ereg("^s",$username))
    {
        $arrayuserpass=file("studentuserpass.txt");
        for($i=0;$i<count($arrayuserpass);$i++)
        {
            $token=explode(",",$arrayuserpass[$i]);
            $user=$token[0];
            $psw=$token[1];
            echo $username . "<br>";
            echo $user . "<br>";
            echo $pass . "<br>";
            echo $psw . "<br>";

            if ($username==$user)
            {
                if ($pass == $psw)
                {
                    //$login="true";
                    echo "Login Sucessfull";
                    exit;
                }
            }
            else
            {
                $login="false";
            }
        }
        if ($login=="false")
        {
            echo "Username and Password not match";
        }
    }

?>

form :

<html>
<body>
<form name="form1" method="post" action="script.php">
  <input type="text" name="username">
  <input type="text" name="pass">
  <input type="submit" name="Submit" value="Submit">
</form>
</body>
</html>

studentuserpass.txt :

username,password

thanks. it seems work perfectly. thanks