hey, im having a slight problem with this script im making, its meant to show what messages the user has sent and who to, connect to the message database and pull out the messages which have the users id as the author, then connect to the user database and pull out the information for the name who it is to, doesnt seem to be working tho... i get the error:

Warning: mysql_close(): no MySQL-Link resource supplied in /home/xingeh/public_html/sentmsgs.php on line 38

this is the code i have :

PHP Code:

 <?
 
 $id =  $HTTP_COOKIE_VARS['id'];
 
 if($_SESSION['username']) {
 
 mysql_connect("stuff") or die("Could not connect to DB because: ".mysql_error());
 mysql_select_db("stuff") or die("Could not select the DB because: ".mysql_error());
 
 echo("Sent messages:");
 echo("<br><br>");
 
 $query=mysql_query("SELECT * FROM messenger WHERE authorid = '$id' ORDER BY messid DESC");
 $num=mysql_num_rows($query);
 $row = mysql_fetch_array($query);
 
 $messid = $row['messid'];
 $messtitle = $row['messtitle'];
 $userid = $row['userid'];
 
 $query2=mysql_query("SELECT * FROM users WHERE id = '$userid'");
 $row2 = mysql_fetch_array($query2);
 
 $username = $row['username'];
 
 if($num == 0) {
 echo("You havent sent any messages!");
 
 } else {
 
 echo("You have sent $num message(s)");
 echo("<br><br>");
 
 echo("[$messid] $messtitle - $username");
 
 
 }}
 
 mysql_close();
 ?>

Your code is written as such so that the MySQL connection is created only if $_SESSION['username'] is true, but mysql_close() is called even if $_SESSION['username'] is false.

According to the PHP Manual for mysql_close:

If the link identifier is not specified, the last link opened by mysql_connect() is assumed. If no such link is found, it will try to create one as if mysql_connect() was called with no arguments. If by chance no connection is found or established, an E_WARNING level warning is generated.

It seems that if no $_SESSION['username'] is supplied, your script tries to close a non-existent MySQL connection by opening a MySQL connection without using the proper arguments, and the error is thrown.

Try this instead:

echo("[$messid] $messtitle - $username");

}
mysql_close();
}

?>

Yeah, take one of the brackets from line 36 and put it AFTER the mysql_close function.

yeah erm.. ive just checked it now, and i found another error i had put $row2...

then $row['username']; ... thats another thing why it wasnt working!

also, i was trying to get it to work last night, and i edited it and kinda lost what i had before, so ive just had to copy this again lol, just up[loaded it, fixed both errors and now i cant log in on my site?

ok, right thats all sorted. There is one new problem. It only shows one message, not all of them, I have 3, it shows 1, can anyone help with that one?

mysql_fetch_array only pulls one row, not the entire dataset. (link)

You will need to loop through the results for the first query... something like...

$results = array();
while ($row = mysql_fetch_array($query)){
$results[] = $row;
}

...will put the results of your query into an array called $results.

You will then need to use the loop of your choice to accomplish echoing your results. Something like...

for($i=0; $i < count($results); $i++)
{
   echo "[" . $results[$i]['messid'] . "] " . $results[$i]['messtitle'] . " - " . $username . "<br />";
}

Untested, of course, but it should put you on the right track as to what sections of the PHP manual to research.

Hope that helps...!

Mike