PHP Forum

**EGS** · 12-09-2005, 07:50 PM

So I tried to code a PHP upload form to upload some images into a folder on my site, but for SOME flippin' reason, it doesn't work!

Please, somebody...tell me what I'm doing wrong!

Code:

<?php
$path = "/home/bgamer/public_html/media";
$url = "http://www.boldgamers.com/media";

if (!$_POST['file']) {
echo '<form method="post" action="upload.php" enctype="multipart/form-data"><input type="file" name="file"> <input type="submit" value="Upload!"></form>';
}

if ($_POST['file']) {
$copy = copy ($_FILES["file"]["tmp_name"], $path."/".$_FILES["file"]["name"]);

if ($copy == TRUE) {
echo "<a href='".$url."/".$_POST["file"]."'>View your file!</a>";
} else {
echo "Nope didnt go through; go back and try again!";
}
}
?>

Note: That IS upload.php also

**Orodreth** · 07:41 AM

You could try this:

PHP Code:


			
<?php

$path = "/home/bgamer/public_html/media";

$url = "http://www.boldgamers.com/media";



if (!is_uploaded_file($_FILES['file']['tmp_name'])) {

echo '<form method="post" action="upload.php" enctype="multipart/form-data"><input type="file" name="file"> <input type="submit" value="Upload!"></form>';

}

else{

$copy = move_uploaded_file($_FILES["file"]["tmp_name"], $path."/".$_FILES["file"]["name"]);



if ($copy == TRUE) {

echo "<a href='".$url."/".$_FILES["file"]["name"]."'>View your file!</a>";

} else {

echo "Nope didnt go through; go back and try again!";

}

}

?>

You shouldn't be using $_POST['file']

Edit: corrected the code

**EGS** · 12-10-2005, 10:55 AM

Ok does this file need to be CHMOD'ed or the directory or no?

I'm going to try this code. ^_^

**EGS** · 12-10-2005, 11:01 AM

I tried this and it gives this error:

Quote:

Originally Posted by PHP Error

Parse error: parse error, unexpected '{' in upload.php on line 23

**execute** · 12-10-2005, 05:19 PM

if (!is_uploaded_file($_FILES['file']['tmp_name']) {

should change to :

if (!is_uploaded_file($_FILES['file']['tmp_name'])) {

**mrpaul** · 12-10-2005, 07:29 PM

i use this for my website and i no it works

HTML Code:

<html>
<h3>File Upload</h3> 
Select a file to upload:<br>
<form action="uploader.php" method="post" 
enctype="multipart/form-data">
<input type="file" name="file" size="45">
<br>
<input type="submit" value="Upload File">
</form>

and the php...

PHP Code:


			
<?php 



       If ( $_FILES['file'] ['name'] != "" ) 

       { 

       copy ( $_FILES['file'] ['tmp_name'], 

       "/uploads" . $_FILES['file']['name'] ) 

   or die ( "Could not copy file" ); 

       } 

       else{ die( "No file specified" ) ; } 

?> 



<h3> Upload Complete, File Upload Succeeded... </h3> 

<ui> 

<li> Sent: <?php echo $_FILES['file'] ['name'] ; ?> 

<li> Size: <?php echo $_FILES['file'] ['size'] ; ?> bytes 

<li> Type:<?php echo $_FILES['file'] ['type'] ; ?> 

</ul> 



<a href="/uploads/<?php echo $_FILES['file'] ['name'] ; ?>"> 

Click here to view the file</a>

**Orodreth** · 12-10-2005, 07:57 PM

PHP Code:


			
"/uploads" . $_FILES['file']['name'] )

should be

PHP Code:


			
"/uploads/" . $_FILES['file']['name'] )

I'd also use move_uploaded_file instead of copy, but I guess it works too.

**EGS** · 12-10-2005, 10:13 PM

Thanks, Orodreth. I decided to use yours - success! It works!

Thanks so much dude!

Thanks everyone for your help! Have a great holiday!

**mrpaul** · 07:31 AM

sorry aobut that ye add the / if u use mine