Please help me. I cannot get this code to work properly. The web page is not properly showing the php code.

echo "<tr class='text1'><td><?php if(".$emailel."=='email') echo '<a href='mailto:".$userel."'><img src='emaillogo.gif'></a>'; else echo ' '; ?></td><td>".$bus."</td><td>".$busc."</td></tr>";}

The variables are pulled correctly. However, the images are not showing when the email matches.

Originally Posted by weddingm

Please help me. I cannot get this code to work properly. The web page is not properly showing the php code.

echo "<tr class='text1'><td><?php if(".$emailel."=='email') echo '<a href='mailto:".$userel."'><img src='emaillogo.gif'></a>'; else echo ' '; ?></td><td>".$bus."</td><td>".$busc."</td></tr>";}

The variables are pulled correctly. However, the images are not showing when the email matches.

You dont need to start the PHP engine after its already been started. Also, you cant have if statements or anything like that inside a echo, and you cant nest echos inside echos.

Here is a proper way to do it:

PHP Code:

echo "<tr class='text1'><td>";
if($emailel == email){
  echo "<a href='mailto:$userel'><img src='emaillogo.gif'></a>";
}
else{
  echo " ";
}
echo "</td><td>$bus</td><td>$busc</td></tr>"; 


That should clear it up hopefully. If not it might be another problem.

It's usually best to limit your usage of using echo for performance reasons, so just store everything in a string first then echo that string:

PHP Code:

<?php
$tmp = '<tr class="text1"><td>';
if($emailel == 'email') {
  $tmp .= '<a href="mailto:'.$userel.'"><img src="emaillogo.gif"></a>';
else {
  $tmp .= '&nbsp;';
}
$tmp .= '</td><td>'.$bus.'</td><td>'.$busc.'</td></tr>';
echo $tmp;
?>

The only problem I noticed with Slick's code is he was using the constant name email not the string 'email' though if the constant email doesn't exist, PHP assumes the string 'email' but it's poor programming to rely on this.

Cheers,

MC

actually that was a typo on my part, forgot to put it in single quotes.

Thanks guys for your help. I got it to work!