I have a problem updating data in a database. Yes, I do have text in the area i want to update. Here is the code...

PHP Code:

<?php

if ( isset ( $_POST['submit'] ) ) {

$contents = $_POST['contents'];

include ( "db_settings.inc.php" );

$sql = "UPDATE open_files SET contents = '{$_POST['contents']}' WHERE id = {$_POST['id']}";

$query = mysql_query ( $sql );

if ( mysql_affected_rows() == 1 );

print "Your file has been updated!";

} else {

print "Your file could not be updated...";

}

?>

I've tried everything...It is probably a simple mistake!

At what point is it failing? Do you get an error? Is a record being inserted but is blank? More evidence required!

Just scanning your code quickly it could be the line

$sql = "UPDATE open_files SET contents = '{$_POST['contents']}' WHERE id = {$_POST['id']}";

Your use of single quotes ' could be breaking the sql statement

Two quick ways to debug this are to either insert a line after that:

print $sql;

and see if PHP errors

or use mysql from the CLI and run the select from the console to see if mysql error's.

One thing I am seeing right off hand is that you are checking $_POST[submit], but then building your query from $_POST[contents]. Why not check isset($_POST[contents]) as well to make sure you're not trying to submit a null or empty string. Similarly, you are not checking $_POST[id] either though it is used.

One thing I always do when I run into a SQL query: Print out the contents of your SQL string then plug it into the query window in phpMyAdmin or similar tool. You will get a much more robust error message.

Also, you are specifically assigning $contents to $_POST[contents], but then continue to use $_POST[contents]. It is not an error, but why are you doing that?

Your script is vulnerable to SQL injection attacks. You need to use addslashes() or mysql_escape_string() on your data (this could also be cause of your problem) - on ALL data before using it a query like this. And you have syntax errors with your last if statement and are missing the last curly brace for the first if statement.

Thanks for the replies! kyrnt, I accidentally deleted that variable in the SQL statment, but by accident i left it there!

But when I update it it does absolutely nothing.

ok, here is the new code!

PHP Code:

<?php

include ( "db_settings.inc.php" );

$sql = "UPDATE open_files SET contents = '{$_POST['contents']}' WHERE id = {$_POST['id']}";

$query = mysql_query ( $sql );

if ( mysql_affected_rows() == 1 ) {

print "Your file has been made!";

} else {

print "Your file could not be made...";

}

?>

So when you run this code, dan, are you at least getting the debug that the file "could not be made?" Or are you getting absolutely nothing?

Now I can get the "File Could not be made."

Still can't get it...Can anyone help?

I'll repeat. Are you getting any errors or is just your 'Your file could not be...' being displayed.

Are you sure the select statement is correct?

Rem out your $sql line and try this:

$sql = "UPDATE open_files SET contents = 'test' WHERE id = 1";

As I said earlier, it could be your use of single quotes ... If you can test if it's that then you can get the solution!

One other point. What if the number of affected rows is greater than 1? You would therefore get a fail.

To debug this just add

print mysql_affected_rows();

I think you are asking a lot of questions when you should be just doing basic debugging techniques :-)