Website Design Forum

**Elderm1** · 04-09-2007, 01:16 PM

Ok... so i have a good design and bad code....
I posted my site for review and most people like my design except for a few things, but my code sucked it up big time.....
... so in order to make the site better and better and hopefully make this into a job someday. but in order to do this i have to start somewhere and get some help along the way. So i started to read more and more of CSS

........ Cant say that it all sank in yet but i started....

here is my test so far,

it works fine in firefox but not in IE

dont know why maybe someone can tell me

CSSTESTLINK

link to the Css Code

HELP ME, I know I need it

THANKS FOR ALL THE COMMENTS

**travelagent** · 04-09-2007, 01:25 PM

There's nothing wrong with your CSS -- for a beginner, you did an excellent job!

But, checking your site, you didn't start it with the mandatory <!DOCTYPE Declaration> for validation and to ensure your site displays properly in all browsers ... therefore, you only have these 9 code warnings to fix:

Code:

line 1 column 1 - Warning: missing <!DOCTYPE> declaration
line 61 column 11 - Warning: <embed> is not approved by W3C
line 61 column 181 - Warning: discarding unexpected </embed>
line 42 column 1 - Warning: <body> proprietary attribute "leftmargin"
line 42 column 1 - Warning: <body> proprietary attribute "topmargin"
line 42 column 1 - Warning: <body> proprietary attribute "marginwidth"
line 42 column 1 - Warning: <body> proprietary attribute "marginheight"
line 45 column 3 - Warning: <table> proprietary attribute "height"
line 81 column 11 - Warning: <a> escaping malformed URI reference

**ADAM Web Design** · 04-09-2007, 03:20 PM

Simply put, your big issue is that you use absolute positioning...a lot. There's nothing wrong with absolute positioning in and of itself, but it should only be used to break up document flow. In your case, you don't want to do that. You can use an unordered list to list off the menu items and a div on either side (top and bottom) for the little boxes.

Also, use classes if you plan on repeating styles more than once per page and IDs (#header, #menu, #footer) for elements that are only displayed once per page.

Those are the two basic concepts that should get you to where you want to go. Now play with them and see where it takes you.