Website Review and Suggestions

**softcreator56** · 06-19-2009, 03:57 PM

folks,plz review this new site http://exceltomysql.com.
Any feedback or suggestion would be appreciated.
thanks

**Orodreth** · 06-19-2009, 05:47 PM

Well, I think your site is based around a very good idea, has a good design and is well structured. The problem is it doesn't really work well yet.

I tried converting one file (attachment), but the sql your site returned was completely invalid (other attachment).

Clearly,

Code:

... e-mail klasgenootjes 6de middelbaar - test ...

should be

Code:

... `e-mail klasgenootjes 6de middelbaar - test` ...

Code:

'"Bachot Tomas"'

should be

Code:

'Bachot Tomas'

and

Code:

`"Emailadres"`

should be

Code:

`Emailadres`

Most csv files contain spaces and quotes. Check that and make sure the content is well escaped. That will make your site useful. Right now, it isn't.

**softcreator56** · 06-22-2009, 11:02 PM

thank you for your suggestions.I really appreciate it.
During design,I had in mind simple csv files created for entering into mysql.(Atleast i never had to enter data into db with quotes and or spaces.But i will look into that and upgrade the site if I could program it that way.

I bet it will be similar problem for my other site (doing viceversa)..plz let me know if any more suggetions.

**softcreator56** · 06-22-2009, 11:21 PM

ohh..i am sorry if i couldn't understnd it properly.I thought you meant that it will not properly add double or singles quotes and spaces when creating mysql table,so i just tested it and it is converiting to mysql exactly how it was in excel sheet.my questions:
1.do you mean that it should NOT convert quotes or spaces in mysql code (if that's the case,there will be some excel sheets that may need that type of data unescaped for ex.while processing input or output from wysiwg editors in html.
2.where do you think i should modify the code (plz be as specific as possible)
3.I plan to change it in near future where the sql code will be emailed to user instead of dispalying in browser,what you think of this as a customer?

**softcreator56** · 06-22-2009, 11:25 PM

woooooooo..i just tried to visit one of your signature sites..and i got the virus advirosry warning..whats up with that ??

**Orodreth** · 06-23-2009, 05:30 AM

Well, what I meant was that mostly when you use excel (or Openoffice.org Calc) to generate csv files, they contain quotes around the strings. This quotes should not be added to the database. To get the content you've got to enter: strip these quotes and add new ones. Or keep them, but check for their presence.

Thank you for taking a look at my website. I've been quite busy lately and didn't check that one for a while now. Apparently, I should have. Everything's fixed now, but there was some security-flaw in it and it got hacked. Let's hope I fixed everything now. I removed the malicious code, and fixed some flaws, but maybe there are more of them. The security warning should be gone soon.